Skip to content

Conversation

@Yash094
Copy link
Member

@Yash094 Yash094 commented Nov 22, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR simplifies the text displayed in the trusted-forwarders-fieldset.tsx component by removing the option for users to click a button for default forwarders provided by thirdweb. It now only mentions the ability to provide a custom forwarder.

Detailed summary

  • The text within the <span> element was changed to remove the option for default forwarders.
  • The updated text now states: "You can provide your own forwarder."

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Nov 22, 2024

⚠️ No Changeset found

Latest commit: 2c40135

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 22, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 22, 2024
@vercel
Copy link

vercel bot commented Nov 22, 2024

@Yash094 is attempting to deploy a commit to the thirdweb Team on Vercel.

A member of the Team first needs to authorize it.

@codecov
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.26%. Comparing base (24f4e5a) to head (2c40135).
Report is 7 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (24f4e5a) and HEAD (2c40135). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (24f4e5a) HEAD (2c40135)
packages 2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5494       +/-   ##
===========================================
- Coverage   43.85%   31.26%   -12.60%     
===========================================
  Files        1075     1072        -3     
  Lines       55944    55718      -226     
  Branches     3907     2923      -984     
===========================================
- Hits        24534    17418     -7116     
- Misses      30727    37635     +6908     
+ Partials      683      665       -18     
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 24f4e5a
packages 22.90% <ø> (-15.68%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 234 files with indirect coverage changes

---- 🚨 Try these New Features:

@jnsdls jnsdls merged commit 7456422 into thirdweb-dev:main Nov 22, 2024
25 of 30 checks passed
@Yash094 Yash094 deleted the yash/update-forwarder-form-text branch November 22, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants