Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Nov 22, 2024

PR-Codex overview

This PR introduces a new component, TextDivider, and integrates it into the OnboardingChoosePlan component. It also modifies the button styles and layout within the OnboardingChoosePlan for better user experience.

Detailed summary

  • Added TextDivider component in TextDivider.tsx.
  • Updated OnboardingChoosePlan to include TextDivider with text "OR".
  • Changed button style from a link variant to an outline variant.
  • Adjusted layout spacing in the grid from md:gap-4 to md:gap-5.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 23, 2024 1:43am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 23, 2024 1:43am
thirdweb_playground ⬜️ Skipped (Inspect) Nov 23, 2024 1:43am
wallet-ui ⬜️ Skipped (Inspect) Nov 23, 2024 1:43am

@vercel vercel bot temporarily deployed to Preview – docs-v2 November 22, 2024 22:54 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Nov 22, 2024

⚠️ No Changeset found

Latest commit: 5e69009

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 22, 2024 22:54 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 22, 2024 22:54 Inactive
@MananTank MananTank marked this pull request as ready for review November 22, 2024 22:54
Copy link
Member Author

MananTank commented Nov 22, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 22, 2024
@codecov
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.09%. Comparing base (7456422) to head (eb72886).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5500   +/-   ##
=======================================
  Coverage   44.09%   44.09%           
=======================================
  Files        1074     1074           
  Lines       55632    55632           
  Branches     3907     3907           
=======================================
  Hits        24533    24533           
  Misses      30416    30416           
  Partials      683      683           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 7456422
packages 38.85% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

---- 🚨 Try these New Features:

@github-actions
Copy link
Contributor

github-actions bot commented Nov 22, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.97 KB (0%) 900 ms (0%) 702 ms (+67.16% 🔺) 1.7 s
thirdweb (cjs) 105.01 KB (0%) 2.2 s (0%) 1.3 s (+76.99% 🔺) 3.4 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 143 ms (+880.52% 🔺) 255 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 137 ms (+2379.67% 🔺) 147 ms
thirdweb/react (minimal + tree-shaking) 18.38 KB (0%) 368 ms (0%) 177 ms (+128.05% 🔺) 545 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 22, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@MananTank MananTank force-pushed the 11-23-update_free_plan_button_copy_and_styles_in_onboarding_plan_selection_screen branch from ba00731 to 5e69009 Compare November 22, 2024 23:42
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 22, 2024 23:42 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 22, 2024 23:42 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 22, 2024 23:42 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 23, 2024

Merge activity

  • Nov 22, 7:20 PM EST: A user added this pull request to the Graphite merge queue.
  • Nov 22, 7:26 PM EST: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Vercel – thirdweb-www', 'check_linear_in_pr_body').
  • Nov 22, 8:43 PM EST: A user added this pull request to the Graphite merge queue.
  • Nov 22, 8:44 PM EST: A user merged this pull request with the Graphite merge queue.

…screen (#5500)

<!-- start pr-codex -->

---

## PR-Codex overview
This PR introduces a new component called `TextDivider` and integrates it into the `OnboardingChoosePlan` component. It also makes adjustments to the layout and button styles within `OnboardingChoosePlan`.

### Detailed summary
- Added `TextDivider` component in `TextDivider.tsx` for displaying a horizontal divider with text.
- Updated `OnboardingChoosePlan` to include `TextDivider` with the text "OR".
- Changed the grid gap from `md:gap-4` to `md:gap-5`.
- Replaced the previous button with a new styled button in `OnboardingChoosePlan`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@jnsdls jnsdls force-pushed the 11-23-update_free_plan_button_copy_and_styles_in_onboarding_plan_selection_screen branch from 5e69009 to eb72886 Compare November 23, 2024 00:21
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 23, 2024 00:21 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 23, 2024 00:21 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 23, 2024 00:21 Inactive
@graphite-app graphite-app bot merged commit eb72886 into main Nov 23, 2024
31 of 32 checks passed
@graphite-app graphite-app bot deleted the 11-23-update_free_plan_button_copy_and_styles_in_onboarding_plan_selection_screen branch November 23, 2024 01:44
@vercel vercel bot temporarily deployed to Production – thirdweb_playground November 23, 2024 01:44 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui November 23, 2024 01:44 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 November 23, 2024 01:44 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants