[Dashboard] Feature: RPC Chart #5504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregfromstl
requested review from
MananTank,
jnsdls and
joaquim-verges
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5504 +/- ##
=======================================
Coverage 43.81% 43.81%
=======================================
Files 1075 1075
Lines 55991 55991
Branches 3908 3908
=======================================
Hits 24534 24534
Misses 30774 30774
Partials 683 683
*This pull request uses carry forward flags. Click here to find out more.
|
Contributor
size-limit report 📦
|
gregfromstl
added
the
merge-queue
Contributor
Author
Merge activity
|
joaquim-verges
approved these changes
Nov 24, 2024
CNCT-2395 <img width="1161" alt="Screenshot 2024-11-22 at 9 52 09 PM" src="https://github.com/user-attachments/assets/e46f1645-11bb-42d5-abcf-147852a3e8ce"> <!-- start pr-codex --> --- ## PR-Codex overview This PR primarily focuses on refactoring the analytics data handling by shifting the source of types from the `@/api/analytics` module to a new `types/analytics` module. This change enhances type definitions and improves code organization. ### Detailed summary - Changed import paths for various analytics types to `types/analytics`. - Added new interfaces in `apps/dashboard/src/types/analytics.ts` for `WalletStats`, `WalletUserStats`, `InAppWalletStats`, `EcosystemWalletStats`, `UserOpStats`, `RpcMethodStats`, and `AnalyticsQueryParams`. - Updated multiple components and utilities to utilize the new type definitions. - Implemented a new RPC method usage function in `apps/dashboard/src/@/api/analytics.ts`. - Added `RpcMethodBarChartCard` component to visualize RPC method usage in `apps/dashboard/src/app/team/[team_slug]/[project_slug]/page.tsx`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
gregfromstl
force-pushed
the
greg/cnct-2395-rpc-analytics-charts
branch
from
20b68b4 to
dfc824d
Compare
vercel
bot
temporarily deployed
to
Production – thirdweb_playground
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CNCT-2395
PR-Codex overview
This PR refactors the analytics-related imports and types, moving them from
@/api/analyticsto a newtypes/analyticsmodule. It enhances type safety and organization by centralizing analytics type definitions.Detailed summary
@/api/analyticstotypes/analytics.types/analytics.ts:WalletStats,WalletUserStats,InAppWalletStats,EcosystemWalletStats,UserOpStats,RpcMethodStats, andAnalyticsQueryParams.getRpcMethodUsageandisProjectActivefunctions in@/api/analytics.RpcMethodBarChartCard.