Skip to content

Conversation

@kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Nov 26, 2024

dash-472


PR-Codex overview

This PR focuses on updating the saving functionality in two components, airdrop-upload.tsx and snapshot-upload.tsx, to ensure that the data being set uses the resolvedAddress instead of potentially incorrect values, and to structure the data appropriately.

Detailed summary

  • In airdrop-upload.tsx:

    • Updated setAirdrop to map over normalizeQuery.data.result and set address and quantity.
  • In snapshot-upload.tsx:

    • Added comments to clarify that resolvedAddress should be used instead of ENS values.
    • Updated setSnapshot to map over normalizeQuery.data.result and set address, maxClaimable, price, and currencyAddress.
    • Reset openSnapshotIndex to -1.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Nov 26, 2024

⚠️ No Changeset found

Latest commit: 2ae404d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 6:22pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 26, 2024 6:22pm
thirdweb_playground ⬜️ Skipped (Inspect) Nov 26, 2024 6:22pm
wallet-ui ⬜️ Skipped (Inspect) Nov 26, 2024 6:22pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 26, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@vercel vercel bot temporarily deployed to Preview – wallet-ui November 26, 2024 17:20 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 26, 2024 17:20 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 26, 2024 17:20 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 26, 2024
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@kien-ngo kien-ngo changed the title update [Dashboard] Parse ENS value to evm address on uploading snapshot & Nov 26, 2024
@kien-ngo kien-ngo changed the title [Dashboard] Parse ENS value to evm address on uploading snapshot & [Dashboard] Parse ENS value to evm address on uploading snapshots Nov 26, 2024
@kien-ngo kien-ngo marked this pull request as ready for review November 26, 2024 17:21
@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.97 KB (0%) 960 ms (0%) 137 ms (+7.33% 🔺) 1.1 s
thirdweb (cjs) 107.2 KB (0%) 2.2 s (0%) 213 ms (-15.63% 🔽) 2.4 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 18 ms (+152.02% 🔺) 130 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 9 ms (+148.99% 🔺) 19 ms
thirdweb/react (minimal + tree-shaking) 18.31 KB (0%) 367 ms (0%) 38 ms (+142.78% 🔺) 404 ms

@codecov
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.84%. Comparing base (480fb4e) to head (2ae404d).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5518   +/-   ##
=======================================
  Coverage   43.84%   43.84%           
=======================================
  Files        1081     1081           
  Lines       56186    56186           
  Branches     3929     3929           
=======================================
  Hits        24635    24635           
  Misses      30868    30868           
  Partials      683      683           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 480fb4e
packages 38.60% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 26, 2024

Merge activity

@jnsdls jnsdls force-pushed the kien/fix-ens-parser-for-snapshot-upload branch from 9b8aa69 to 2ae404d Compare November 26, 2024 18:17
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 26, 2024 18:17 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 26, 2024 18:17 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 26, 2024 18:17 Inactive
@graphite-app graphite-app bot merged commit 2ae404d into main Nov 26, 2024
29 checks passed
@graphite-app graphite-app bot deleted the kien/fix-ens-parser-for-snapshot-upload branch November 26, 2024 18:22
@vercel vercel bot temporarily deployed to Production – docs-v2 November 26, 2024 18:22 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui November 26, 2024 18:22 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground November 26, 2024 18:22 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants