Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Nov 26, 2024

DASH-475


PR-Codex overview

This PR updates the href attribute of a Link component in the app-footer.tsx file to change the destination from the root (/) to the /home route.

Detailed summary

  • Changed the href attribute of the Link component from "/" to "/home" in apps/dashboard/src/@/components/blocks/app-footer.tsx.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 6:55pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 26, 2024 6:55pm
thirdweb_playground ⬜️ Skipped (Inspect) Nov 26, 2024 6:55pm
wallet-ui ⬜️ Skipped (Inspect) Nov 26, 2024 6:55pm

@changeset-bot
Copy link

changeset-bot bot commented Nov 26, 2024

⚠️ No Changeset found

Latest commit: 708c353

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 26, 2024 18:13 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 26, 2024 18:13 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 26, 2024 18:13 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 26, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 26, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank marked this pull request as ready for review November 26, 2024 18:13
@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.97 KB (0%) 960 ms (0%) 588 ms (+135.64% 🔺) 1.6 s
thirdweb (cjs) 107.2 KB (0%) 2.2 s (0%) 838 ms (+68.5% 🔺) 3 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 108 ms (+760.58% 🔺) 220 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 5 ms (+44.93% 🔺) 15 ms
thirdweb/react (minimal + tree-shaking) 18.31 KB (0%) 367 ms (0%) 174 ms (+600.49% 🔺) 540 ms

@codecov
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.84%. Comparing base (9ef8b39) to head (708c353).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5521   +/-   ##
=======================================
  Coverage   43.84%   43.84%           
=======================================
  Files        1081     1081           
  Lines       56186    56186           
  Branches     3929     3929           
=======================================
  Hits        24635    24635           
  Misses      30868    30868           
  Partials      683      683           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 9ef8b39
packages 38.60% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 26, 2024

Merge activity

@jnsdls jnsdls force-pushed the 11-26-fix_home_link_in_dashboard_footer branch from 4940d44 to 708c353 Compare November 26, 2024 18:46
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 26, 2024 18:46 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 26, 2024 18:46 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 26, 2024 18:46 Inactive
@graphite-app graphite-app bot merged commit 708c353 into main Nov 26, 2024
29 checks passed
@graphite-app graphite-app bot deleted the 11-26-fix_home_link_in_dashboard_footer branch November 26, 2024 18:56
@vercel vercel bot temporarily deployed to Production – docs-v2 November 26, 2024 18:56 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground November 26, 2024 18:56 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui November 26, 2024 18:56 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants