Skip to content

Conversation

@Joe-Thirdweb
Copy link
Contributor

@Joe-Thirdweb Joe-Thirdweb commented Nov 27, 2024

Problem solved

Adding custom chain banners , about, and CTA for

  • Lisk Testnet (4202)
  • Lisk Mainnet (1135)
  • Hashfire Mainnet (4227)
  • Laos Mainnet (6283)
  • Etherlink Testnet (128123)
  • Etherlink Mainnet (42793)

PR-Codex overview

This PR focuses on adding new assets and metadata for various blockchain projects, including Etherlink, Hashfire, LAOS, and Lisk, to enhance the dashboard's functionality and user experience.

Detailed summary

  • Added image imports for etherlinkBanner, etherlinkCTA, hashfireBanner, hashfireCTA, laosBanner, laosCTA, liskBanner, and liskCTA.
  • Introduced metadata entries for Etherlink (testnet and mainnet), Hashfire, LAOS, and Lisk (testnet and mainnet) in chainMetaRecord.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Nov 27, 2024

⚠️ No Changeset found

Latest commit: aee1ac5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2024 7:07pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 27, 2024 7:07pm
thirdweb_playground ⬜️ Skipped (Inspect) Nov 27, 2024 7:07pm
wallet-ui ⬜️ Skipped (Inspect) Nov 27, 2024 7:07pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 27, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 27, 2024
@Joe-Thirdweb Joe-Thirdweb changed the title Joe - A Joe - Adding Chain claim updates Nov 27, 2024
@codecov
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.19%. Comparing base (7488102) to head (aee1ac5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5534   +/-   ##
=======================================
  Coverage   46.19%   46.19%           
=======================================
  Files        1081     1081           
  Lines       58613    58613           
  Branches     3933     3933           
=======================================
  Hits        27075    27075           
  Misses      30855    30855           
  Partials      683      683           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 6be96e5
packages 41.75% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@vercel vercel bot temporarily deployed to Preview – wallet-ui November 27, 2024 18:57 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 27, 2024 18:57 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 27, 2024 18:57 Inactive
4202: {
headerImgUrl: liskBanner.src,
about:
"Lisk is focused on serving builders in high-growth markets like Africa and Southeast Asia. When you build on Lisk, you become part of the strongest Ethereum collective, alongside Coinbase, Sony, World, Kraken and Uniswap -- the OP Superchain.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The about text for Lisk appears to contain content from an OP Superchain description. Lisk is an independent blockchain platform with its own SDK, consensus mechanism, and ecosystem. The description should be updated to accurately reflect Lisk's core features and value proposition. Consider referencing Lisk's JavaScript-based development environment, its modular architecture, or its focus on blockchain application development.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.92 KB (0%) 959 ms (0%) 4.5 s (+29.93% 🔺) 5.5 s
thirdweb (cjs) 107.27 KB (0%) 2.2 s (0%) 7.5 s (+2.9% 🔺) 9.6 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 230 ms (-36.76% 🔽) 342 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 78 ms (+102% 🔺) 88 ms
thirdweb/react (minimal + tree-shaking) 18.28 KB (0%) 366 ms (0%) 707 ms (+66.88% 🔺) 1.1 s

@Joe-Thirdweb Joe-Thirdweb added the merge-queue Adds the pull request to Graphite's merge queue. label Nov 27, 2024
Copy link
Contributor Author

Merge activity

  • Nov 27, 2:52 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

@jnsdls jnsdls merged commit e87eb2f into main Nov 27, 2024
30 of 31 checks passed
@jnsdls jnsdls deleted the Joe-Claim-Chain-Updates branch November 27, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. merge-queue Adds the pull request to Graphite's merge queue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants