updated to use contractInfo name #5536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GWSzeto
requested review from
MananTank,
jnsdls and
joaquim-verges
as code owners
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5536 +/- ##
=======================================
Coverage 46.19% 46.19%
=======================================
Files 1081 1081
Lines 58613 58613
Branches 3933 3933
=======================================
Hits 27075 27075
Misses 30855 30855
Partials 683 683
*This pull request uses carry forward flags. Click here to find out more. |
Contributor
size-limit report 📦
|
GWSzeto
force-pushed
the
erc20-token-id-bug
branch
from
9c73d62 to
4487295
Compare
joaquim-verges
approved these changes
Nov 28, 2024
Contributor
Author
Merge activity
|
https://linear.app/thirdweb/issue/DASH-489/modules-ui-bug-with-erc20-modules-showing-tokenid <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on refactoring the handling of different ERC token types in various components of a dashboard application. It replaces boolean flags with string identifiers for token types, enhancing clarity and maintainability. ### Detailed summary - Replaced boolean flags (`isErc721`, `isErc20`) with string identifiers (`name`) for token types in multiple components. - Updated metadata upload logic to use `props.contractInfo.name` for conditional checks. - Refactored the `uploadMetadata`, `setTransferable`, and `mint` functions to use the new string identifiers. - Modified UI components to use `Select` for token type selection instead of checkboxes. - Adjusted condition checks for enabling transfer and minting based on the updated token type handling. - Updated the `ClaimableModule` to handle ERC20 and ERC721 claims with the new string-based approach. - Ensured consistent handling of token decimals and claim conditions based on token type. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
GWSzeto
force-pushed
the
erc20-token-id-bug
branch
from
9042cb3 to
e2754df
Compare
vercel
bot
temporarily deployed
to
Production – thirdweb_playground
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/thirdweb/issue/DASH-489/modules-ui-bug-with-erc20-modules-showing-tokenid
PR-Codex overview
This PR focuses on refactoring the handling of ERC token types across various components to improve clarity and maintainability. It replaces boolean flags for token types with string identifiers, streamlining the logic for determining contract behavior based on the token type.
Detailed summary
uploadMetadata,transferable, andmintablelogic to useprops.contractInfo.name.Selectfor token type selection instead of checkboxes.