Fix Portal > Contracts overview page links #5541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
github-actions
bot
added
Dashboard
MananTank
requested review from
gregfromstl,
jnsdls and
joaquim-verges
as code owners
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
apps/portal/src/app/connect/in-app-wallet/guides/interact-blockchain/page.mdx
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5541 +/- ##
=======================================
Coverage 46.19% 46.19%
=======================================
Files 1081 1081
Lines 58613 58613
Branches 3933 3933
=======================================
Hits 27075 27075
Misses 30855 30855
Partials 683 683
*This pull request uses carry forward flags. Click here to find out more. |
gregfromstl
approved these changes
Dec 1, 2024
Contributor
gregfromstl
left a comment
gregfromstl
left a comment
There was a problem hiding this comment.
LGTM besides the typo graphite flagged
MananTank
force-pushed
the
12-01-fix_portal_contracts_overview_page_links
branch
from
d82a4cd to
159c057
Compare
apps/portal/src/app/react/v5/in-app-wallet/how-to/interact-blockchain/page.mdx
Outdated
Show resolved
Hide resolved
MananTank
force-pushed
the
12-01-fix_portal_contracts_overview_page_links
branch
from
159c057 to
991d557
Compare
Contributor
size-limit report 📦
|
jnsdls
approved these changes
Dec 1, 2024
Contributor
Merge activity
|
Fixes: DASH-487 <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on updating references to smart contract interaction links throughout the application, simplifying the URLs to point directly to `/contracts` instead of specific interaction overview pages. ### Detailed summary - Updated `href` in `page.tsx` from `/contracts/interact/overview` to `/contracts`. - Changed references in `interact-blockchain/page.mdx` to point to `/contracts`. - Modified links in `contracts/page.mdx` to `/contracts`. - Adjusted links in `sdk.tsx` to `https://portal.thirdweb.com/contracts`. - Updated SDK documentation links in `ipfs/page.mdx` to `/contracts`. - Changed SDK references in `gas/page.mdx` to `/contracts`. - Updated redirects in `redirects.mjs` for `/sdk`, `/sdk/how-it-works`, and `/sdk/getting-started` to `/contracts`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
MananTank
force-pushed
the
12-01-fix_portal_contracts_overview_page_links
branch
from
991d557 to
393d0cf
Compare
graphite-app
bot
deleted the
12-01-fix_portal_contracts_overview_page_links
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: DASH-487
PR-Codex overview
This PR focuses on updating references related to smart contract interactions throughout the application, specifically changing URLs from
/contracts/interact/overviewto/contractsfor improved navigation and clarity.Detailed summary
hrefinapps/portal/src/app/page.tsxfrom/contracts/interact/overviewto/contracts.apps/portal/src/app/connect/in-app-wallet/guides/interact-blockchain/page.mdxto use/contracts.apps/portal/src/app/contracts/page.mdxto point to/contracts.apps/portal/src/app/react/v5/in-app-wallet/how-to/interact-blockchain/page.mdxlinks to/contracts.apps/portal/src/app/contracts/explore/pre-built-contracts/nft-drop/page.mdxto refer to/contracts.buttonLinkinapps/dashboard/src/pages/sdk.tsxfromhttps://portal.thirdweb.com/contracts/interact/overviewtohttps://portal.thirdweb.com/contracts.apps/portal/src/app/glossary/ipfs/page.mdxto link to/contracts.apps/portal/src/app/glossary/gas/page.mdxfrom/contracts/interact/overviewto/contracts.apps/portal/redirects.mjsto point/sdk,/sdk/how-it-works, and/sdk/getting-startedto/contracts.