Skip to content

Conversation

@saminacodes
Copy link
Member

@saminacodes saminacodes commented Dec 1, 2024

Problem solved

Short description of the bug fixed or feature added. PROT-926


PR-Codex overview

This PR focuses on enhancing the documentation for various smart contract types by adding new ContractDeployCard components, improving the clarity of contract descriptions, and updating the environment configuration for issue prefixes.

Detailed summary

  • Updated VALID_ISSUE_PREFIXES in .github/workflows/issue.yml to include PROT.
  • Added ContractDeployCard components to multiple .mdx files for:
    • token
    • edition-drop
    • open-edition
    • token-drop
    • nft-collection
    • nft-drop
    • edition
  • Enhanced descriptions for each contract type.
  • Improved the overall structure and readability of contract documentation.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Dec 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 5:44pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 5:44pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 5:44pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 5:44pm

@vercel vercel bot temporarily deployed to Preview – thirdweb-www December 1, 2024 22:05 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 1, 2024 22:05 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 1, 2024 22:05 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Dec 1, 2024

⚠️ No Changeset found

Latest commit: b30a814

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 1, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@codecov
Copy link

codecov bot commented Dec 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.86%. Comparing base (0aa2416) to head (b30a814).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5547   +/-   ##
=======================================
  Coverage   47.86%   47.86%           
=======================================
  Files        1088     1088           
  Lines       56667    56667           
  Branches     4314     4314           
=======================================
  Hits        27122    27122           
  Misses      28847    28847           
  Partials      698      698           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 0aa2416
packages 43.62% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.72 KB (0%) 915 ms (0%) 712 ms (+32.29% 🔺) 1.7 s
thirdweb (cjs) 106.26 KB (0%) 2.2 s (0%) 1.7 s (+40.09% 🔺) 3.8 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 115 ms (+72.44% 🔺) 227 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 9 ms (-18.47% 🔽) 19 ms
thirdweb/react (minimal + tree-shaking) 18.74 KB (0%) 375 ms (0%) 101 ms (+53.23% 🔺) 476 ms

@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Dec 3, 2024
Copy link
Contributor

gregfromstl commented Dec 3, 2024

Merge activity

  • Dec 3, 4:45 AM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 6, 12:40 PM EST: A user added this pull request to the Graphite merge queue.
  • Dec 6, 12:44 PM EST: A user merged this pull request with the Graphite merge queue.

## Problem solved

Short description of the bug fixed or feature added. PROT-926

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on enhancing documentation for various smart contracts by adding new components and updating existing content. It introduces new `ContractDeployCard` elements to highlight modular contract options and expands the description of certain contracts.

### Detailed summary
- Updated `VALID_ISSUE_PREFIXES` in `.github/workflows/issue.yml` to include `PROT`.
- Added `ContractDeployCard` components in multiple `.mdx` files for:
  - `Modular Token`
  - `Modular Edition Drop`
  - `Modular Open Edition`
  - `Modular Token Drop`
  - `Modular NFT Collection`
  - `Modular NFT Drop`
  - `Modular Edition`
- Revised introduction and features sections in `apps/portal/src/app/contracts/page.mdx`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-queue Adds the pull request to Graphite's merge queue. Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants