Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Dec 2, 2024

DASH-502


PR-Codex overview

This PR focuses on removing an unused Image component from the GetStartedWithContractsDeploy function in the apps/dashboard/src/app/account/contracts/_components/GetStartedWithContractsDeploy.tsx file.

Detailed summary

  • Removed the Image component that displayed an asset based on the activeTab value.
  • Adjusted the code structure by eliminating unnecessary lines related to the Image component.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Dec 2, 2024

⚠️ No Changeset found

Latest commit: e198709

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 9:03pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Dec 2, 2024 9:03pm
thirdweb_playground ⬜️ Skipped (Inspect) Dec 2, 2024 9:03pm
wallet-ui ⬜️ Skipped (Inspect) Dec 2, 2024 9:03pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui December 2, 2024 20:17 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 2, 2024 20:17 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 2, 2024 20:17 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 2, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@MananTank MananTank marked this pull request as ready for review December 2, 2024 20:17
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Dec 2, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.32%. Comparing base (009d31b) to head (e198709).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5557   +/-   ##
=======================================
  Coverage   46.32%   46.32%           
=======================================
  Files        1082     1082           
  Lines       58672    58672           
  Branches     3950     3950           
=======================================
  Hits        27178    27178           
  Misses      30811    30811           
  Partials      683      683           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 009d31b
packages 41.91% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.92 KB (0%) 959 ms (0%) 499 ms (+27.03% 🔺) 1.5 s
thirdweb (cjs) 107.33 KB (0%) 2.2 s (0%) 986 ms (-0.84% 🔽) 3.2 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 87 ms (+239.75% 🔺) 199 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 25 ms (+343.97% 🔺) 35 ms
thirdweb/react (minimal + tree-shaking) 18.28 KB (0%) 366 ms (0%) 121 ms (+132.77% 🔺) 487 ms

@MananTank MananTank changed the title Remove icon from get started with contracts step card Remove icon from get started with contracts step card tabs Dec 2, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 2, 2024

Merge activity

@jnsdls jnsdls force-pushed the 12-03-remove_icon_from_get_started_with_contracts_step_card branch from d061305 to e198709 Compare December 2, 2024 20:47
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 2, 2024 20:47 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 2, 2024 20:47 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 2, 2024 20:47 Inactive
@graphite-app graphite-app bot merged commit e198709 into main Dec 2, 2024
32 checks passed
@graphite-app graphite-app bot deleted the 12-03-remove_icon_from_get_started_with_contracts_step_card branch December 2, 2024 21:04
@vercel vercel bot temporarily deployed to Production – thirdweb_playground December 2, 2024 21:04 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui December 2, 2024 21:04 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 December 2, 2024 21:04 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants