[Dashboard] Fix all crashing stories in storybook #5610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
MananTank
force-pushed
the
12-04-_dashboard_fix_all_crashing_stories_in_storybook
branch
from
e01c53a to
da30248
Compare
Contributor
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5610 +/- ##
=======================================
Coverage 44.92% 44.92%
=======================================
Files 1083 1083
Lines 56326 56326
Branches 4061 4061
=======================================
Hits 25306 25306
Misses 30337 30337
Partials 683 683
*This pull request uses carry forward flags. Click here to find out more. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
MananTank
force-pushed
the
12-04-_dashboard_fix_all_crashing_stories_in_storybook
branch
from
da30248 to
027f21a
Compare
MananTank
changed the base branch from
12-04-replace_login_links_with_button_router_push
to
main
MananTank
force-pushed
the
12-04-_dashboard_fix_all_crashing_stories_in_storybook
branch
from
027f21a to
be80044
Compare
jnsdls
requested changes
Dec 4, 2024
...dashboard)/(chain)/[chain_id]/[contractAddress]/modules/components/batchMetadata.stories.tsx
Show resolved
Hide resolved
MananTank
force-pushed
the
12-04-_dashboard_fix_all_crashing_stories_in_storybook
branch
from
be80044 to
1048483
Compare
jnsdls
approved these changes
Dec 5, 2024
Contributor
Merge activity
|
Fixes DASH-493 <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on enhancing the billing and checkout functionalities within the dashboard application. It introduces new props for redirecting to checkout and billing portals, updates UI components, and replaces the `CustomConnectWallet` with a `ConnectButton`. ### Detailed summary - Updated `TransactionButton` to streamline className handling. - Added `redirectToCheckout` prop in various components including `PageContent`, `OnboardingUI`, and `PlanInfoCard`. - Introduced `RedirectBillingCheckoutAction` type in `billing.ts`. - Replaced `CustomConnectWallet` with `ConnectButton` in several components. - Enhanced `BillingPricing` and `PricingCard` components to accept `redirectToCheckout`. - Added stubs for `redirectToBillingPortal` in story files for testing. - Improved UI consistency across billing-related components. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
jnsdls
force-pushed
the
12-04-_dashboard_fix_all_crashing_stories_in_storybook
branch
from
1048483 to
91f3b4b
Compare
graphite-app
bot
deleted the
12-04-_dashboard_fix_all_crashing_stories_in_storybook
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DASH-493
PR-Codex overview
This PR primarily focuses on integrating the
redirectToCheckoutfunctionality across various components, enhancing the billing process, and improving UI elements for better user experience.Detailed summary
TransactionButtonto streamline class names.redirectToCheckoutinLoginPage,OnboardingUI,ChoosePlan, andPlanInfoCard.CheckoutButtonandBillingPortalButtonwith new redirect actions.ConnectButtoninstead ofCustomConnectWallet.FaucetButtonto replace wallet connection logic with a sign-in button.PricingCardto support additional checkout functionality.