Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Dec 4, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on updating redirect paths and documentation links related to wallet sign-in methods, ensuring consistency in the navigation structure and improving user guidance.

Detailed summary

  • Updated redirects in apps/portal/redirects.mjs.
  • Changed sign-in method links in apps/portal/src/app/connect/wallet/pregenerate-wallets/page.mdx.
  • Modified documentation in packages/thirdweb/src/wallets/in-app/web/ecosystem.ts and packages/thirdweb/src/wallets/in-app/web/in-app.ts to point to the new configuration page.
  • Revised guest mode login instructions in apps/portal/src/app/connect/wallet/sign-in-methods/guest/page.mdx.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Dec 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 3:00am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 3:00am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 3:00am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 3:00am

@changeset-bot
Copy link

changeset-bot bot commented Dec 4, 2024

⚠️ No Changeset found

Latest commit: 5880595

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 4, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@joaquim-verges joaquim-verges marked this pull request as ready for review December 4, 2024 21:30
@joaquim-verges joaquim-verges requested a review from a team as a code owner December 4, 2024 21:30
@joaquim-verges joaquim-verges requested a review from a team December 4, 2024 21:30
@joaquim-verges joaquim-verges requested review from a team, gregfromstl and jnsdls as code owners December 4, 2024 21:30
@github-actions github-actions bot added Portal Involves changes to the Portal (docs) codebase. packages SDK Involves changes to the thirdweb SDK labels Dec 4, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.96 KB (0%) 960 ms (0%) 390 ms (+65.51% 🔺) 1.4 s
thirdweb (cjs) 107.42 KB (0%) 2.2 s (0%) 885 ms (+39.27% 🔺) 3.1 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 69 ms (+405.14% 🔺) 181 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 24 ms (+453.13% 🔺) 34 ms
thirdweb/react (minimal + tree-shaking) 18.3 KB (0%) 367 ms (0%) 149 ms (+235.65% 🔺) 515 ms

@codecov
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.30%. Comparing base (33c23e7) to head (5880595).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5619   +/-   ##
=======================================
  Coverage   44.29%   44.30%           
=======================================
  Files        1082     1082           
  Lines       56261    56261           
  Branches     3992     3993    +1     
=======================================
+ Hits        24919    24924    +5     
+ Misses      30659    30654    -5     
  Partials      683      683           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 33c23e7
packages 39.17% <ø> (+0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...kages/thirdweb/src/wallets/in-app/web/ecosystem.ts 70.37% <ø> (ø)
packages/thirdweb/src/wallets/in-app/web/in-app.ts 60.00% <ø> (ø)

... and 2 files with indirect coverage changes

@joaquim-verges joaquim-verges merged commit b4eed8a into main Dec 5, 2024
31 of 32 checks passed
@joaquim-verges joaquim-verges deleted the docs_Update_Connect_wallet_sign-in_method_URLs branch December 5, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages Portal Involves changes to the Portal (docs) codebase. SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants