Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Dec 5, 2024

Problem solved

PROD-942


PR-Codex overview

This PR focuses on updating the documentation for wallet integration across various platforms, emphasizing ecosystem wallets and refining the sidebar navigation structure.

Detailed summary

  • Updated descriptions for ArticleIconCard components to reflect ecosystem wallets.
  • Modified sidebar structure for better organization of wallet-related links.
  • Removed unused imports and consolidated links under relevant sections.
  • Added new links for user management features.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 7:38pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
thirdweb_playground ⬜️ Skipped (Inspect) Dec 5, 2024 7:38pm
thirdweb-www ⬜️ Skipped (Inspect) Dec 5, 2024 7:38pm
wallet-ui ⬜️ Skipped (Inspect) Dec 5, 2024 7:38pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui December 5, 2024 08:55 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 5, 2024 08:55 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Dec 5, 2024

⚠️ No Changeset found

Latest commit: 49b34f1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – thirdweb-www December 5, 2024 08:55 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 5, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Dec 5, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges marked this pull request as ready for review December 5, 2024 08:55
@joaquim-verges joaquim-verges requested a review from a team as a code owner December 5, 2024 08:55
@joaquim-verges joaquim-verges requested a review from a team December 5, 2024 08:55
@joaquim-verges joaquim-verges requested a review from a team as a code owner December 5, 2024 08:55
@codecov
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.89%. Comparing base (b4eed8a) to head (49b34f1).
Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5625   +/-   ##
=======================================
  Coverage   45.89%   45.89%           
=======================================
  Files        1083     1083           
  Lines       56333    56333           
  Branches     4123     4123           
=======================================
  Hits        25853    25853           
  Misses      29788    29788           
  Partials      692      692           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from b4eed8a
packages 41.15% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.96 KB (0%) 960 ms (0%) 657 ms (-41.63% 🔽) 1.7 s
thirdweb (cjs) 107.42 KB (0%) 2.2 s (0%) 1.8 s (+8.36% 🔺) 4 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 59 ms (+38.04% 🔺) 170 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 9 ms (-33.44% 🔽) 19 ms
thirdweb/react (minimal + tree-shaking) 18.3 KB (0%) 367 ms (0%) 100 ms (+31.72% 🔺) 466 ms

@joaquim-verges joaquim-verges force-pushed the _Documentation_Refactor_Reorganize_Connect_sidebar_and_simplify_guides branch from 7c7fcc0 to 49b34f1 Compare December 5, 2024 19:31
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 5, 2024 19:31 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 5, 2024 19:31 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www December 5, 2024 19:31 Inactive
@joaquim-verges joaquim-verges merged commit 7bbc173 into main Dec 6, 2024
31 of 33 checks passed
@joaquim-verges joaquim-verges deleted the _Documentation_Refactor_Reorganize_Connect_sidebar_and_simplify_guides branch December 6, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants