Skip to content

Conversation

@digiorgiu
Copy link
Contributor

@digiorgiu digiorgiu commented Dec 5, 2024

In Server Side Setup change THIRDWEB_ADMIN_PRIVATE_KEY to AUTH_PRIVATE_KEY since the last is used in .env setup proposed

Problem solved

Fix a env variable typo


PR-Codex overview

This PR updates the environment variable used for authentication in the page.mdx file, changing it from THIRDWEB_ADMIN_PRIVATE_KEY to AUTH_PRIVATE_KEY.

Detailed summary

  • Changed the assignment of privateKey from process.env.THIRDWEB_ADMIN_PRIVATE_KEY to process.env.AUTH_PRIVATE_KEY.
  • Updated the error message from "Missing THIRDWEB_ADMIN_PRIVATE_KEY in .env file." to "Missing AUTH_PRIVATE_KEY in .env file."

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

In Server Side Setup change THIRDWEB_ADMIN_PRIVATE_KEY to AUTH_PRIVATE_KEY since the last is used in .env setup proposed

Signed-off-by: theItalianDev <italiandev@protonmail.com>
@digiorgiu digiorgiu requested a review from a team as a code owner December 5, 2024 09:50
@digiorgiu digiorgiu requested a review from a team December 5, 2024 09:50
@digiorgiu digiorgiu requested a review from a team as a code owner December 5, 2024 09:50
@changeset-bot
Copy link

changeset-bot bot commented Dec 5, 2024

⚠️ No Changeset found

Latest commit: ddc8f00

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 5, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@vercel
Copy link

vercel bot commented Dec 5, 2024

@theitaliandev is attempting to deploy a commit to the thirdweb Team on Vercel.

A member of the Team first needs to authorize it.

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 5, 2024 09:50 Inactive
@vercel
Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
thirdweb_playground ⬜️ Skipped (Inspect) Dec 5, 2024 9:50am

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Dec 5, 2024
@gregfromstl gregfromstl merged commit 5fd5186 into thirdweb-dev:main Dec 8, 2024
6 of 12 checks passed
@codecov
Copy link

codecov bot commented Dec 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.87%. Comparing base (b4eed8a) to head (ddc8f00).
Report is 30 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5626       +/-   ##
===========================================
- Coverage   45.89%   32.87%   -13.02%     
===========================================
  Files        1083     1080        -3     
  Lines       56333    56107      -226     
  Branches     4123     3071     -1052     
===========================================
- Hits        25853    18446     -7407     
- Misses      29788    36987     +7199     
+ Partials      692      674       -18     
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from b4eed8a
packages 24.98% <ø> (-16.18%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 247 files with indirect coverage changes

@digiorgiu digiorgiu deleted the patch-1 branch December 8, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants