Skip to content

Conversation

@Joe-Thirdweb
Copy link
Contributor

@Joe-Thirdweb Joe-Thirdweb commented Dec 5, 2024

Problem solved

  • Adding Lisk Mainnet to the available grants
  • Adding Arena -Z to the coming soon List
    image

Linear ticket

DASH-544


PR-Codex overview

This PR focuses on adding Lisk and ArenaZ to the superchain feature, updating the ApplyForOpCreditsForm component, and modifying the cta structure in the utils.ts file.

Detailed summary

  • Added Lisk to the chain options in ApplyForOpCreditsForm.tsx.
  • Updated about section for Lisk in utils.ts.
  • Commented out existing cta structure in utils.ts and replaced it with OP_CTA.
  • Introduced Lisk and ArenaZ entries in superchain.tsx.
  • Removed old Lisk entry from superchain.tsx.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Dec 5, 2024

⚠️ No Changeset found

Latest commit: c186f63

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 9:13pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Dec 5, 2024 9:13pm
thirdweb_playground ⬜️ Skipped (Inspect) Dec 5, 2024 9:13pm
wallet-ui ⬜️ Skipped (Inspect) Dec 5, 2024 9:13pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 5, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@Joe-Thirdweb Joe-Thirdweb added the merge-queue Adds the pull request to Graphite's merge queue. label Dec 5, 2024
Copy link
Contributor Author

Joe-Thirdweb commented Dec 5, 2024

Merge activity

  • Dec 5, 3:49 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 5, 4:08 PM EST: A user added this pull request to the Graphite merge queue.
  • Dec 5, 4:13 PM EST: A user merged this pull request with the Graphite merge queue.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Dec 5, 2024
@codecov
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.89%. Comparing base (0f4dfd1) to head (c186f63).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5633   +/-   ##
=======================================
  Coverage   45.89%   45.89%           
=======================================
  Files        1083     1083           
  Lines       56333    56333           
  Branches     4123     4123           
=======================================
  Hits        25853    25853           
  Misses      29788    29788           
  Partials      692      692           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 0f4dfd1
packages 41.15% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.96 KB (0%) 960 ms (0%) 2.9 s (-5.27% 🔽) 3.8 s
thirdweb (cjs) 107.42 KB (0%) 2.2 s (0%) 6.6 s (-4.67% 🔽) 8.7 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 168 ms (-72.36% 🔽) 280 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 139 ms (+190.04% 🔺) 149 ms
thirdweb/react (minimal + tree-shaking) 18.3 KB (0%) 367 ms (0%) 426 ms (-67.22% 🔽) 792 ms

Copy link
Member

@jnsdls jnsdls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing linked linear ticket otherwise LGTM

## Problem solved
 - Adding Lisk Mainnet to the available grants
- Adding Arena -Z to the coming soon List
![image](https://github.com/user-attachments/assets/22d67963-0bdb-4737-9bbb-36ac591cc3a8)

## Linear ticket
DASH-544

<!-- start pr-codex -->

---

## PR-Codex overview
This PR introduces `Lisk` as a new entry in the onboarding process and modifies the `cta` structure in the `utils.ts` file. It also adds an `ArenaZ` entry to the `superchains` array while removing a previous `Lisk` entry.

### Detailed summary
- Added `Lisk` to the chain mapping in `ApplyForOpCreditsForm.tsx`.
- Commented out the previous `cta` structure in `utils.ts` and replaced it with `OP_CTA`.
- Set `gasSponsored` to `true` in `utils.ts`.
- Added `ArenaZ` to the `superchains` array in `superchain.tsx`.
- Removed the previous `Lisk` entry from the `superchains` array in `superchain.tsx`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@Joe-Thirdweb Joe-Thirdweb force-pushed the Joe---ArenaZ/Lisk-Superchain-Update branch from de062e9 to c186f63 Compare December 5, 2024 21:08
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 5, 2024 21:08 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 5, 2024 21:08 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 5, 2024 21:08 Inactive
@Joe-Thirdweb
Copy link
Contributor Author

missing linked linear ticket otherwise LGTM

Updated PR body with linear ticket. Thank you sir.

@graphite-app graphite-app bot merged commit c186f63 into main Dec 5, 2024
32 checks passed
@graphite-app graphite-app bot deleted the Joe---ArenaZ/Lisk-Superchain-Update branch December 5, 2024 21:13
@vercel vercel bot temporarily deployed to Production – thirdweb_playground December 5, 2024 21:13 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 December 5, 2024 21:13 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui December 5, 2024 21:13 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. merge-queue Adds the pull request to Graphite's merge queue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants