Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Dec 17, 2024

Problem solved

fixes CNCT-2713


PR-Codex overview

This PR focuses on enhancing the wallet UI by adding support for the Treasure chain and improving error handling for NFT fetching.

Detailed summary

  • Added support for Treasure with id: 61166 in simplehash.ts.
  • Modified error handling in erc721.ts to log the error and return an empty response instead of throwing an error.
  • Updated ConnectButton.tsx to include Treasure in the list of chains for the ThirdwebConnectButton.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 9:10am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Dec 17, 2024 9:10am
thirdweb_playground ⬜️ Skipped (Inspect) Dec 17, 2024 9:10am
thirdweb-www ⬜️ Skipped (Inspect) Dec 17, 2024 9:10am

@github-actions github-actions bot added the Ecosystem Portal Involves changes to the Ecosystem Portal label Dec 17, 2024
@joaquim-verges joaquim-verges marked this pull request as ready for review December 17, 2024 08:41
@changeset-bot
Copy link

changeset-bot bot commented Dec 17, 2024

⚠️ No Changeset found

Latest commit: ea23046

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@linear
Copy link

linear bot commented Dec 17, 2024

@codecov
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.99%. Comparing base (7bc2856) to head (ea23046).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5769   +/-   ##
=======================================
  Coverage   52.99%   52.99%           
=======================================
  Files        1102     1102           
  Lines       59107    59107           
  Branches     4809     4809           
=======================================
  Hits        31323    31323           
  Misses      27066    27066           
  Partials      718      718           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 7bc2856
packages 50.13% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 17, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.93 KB (0%) 899 ms (0%) 208 ms (+22.51% 🔺) 1.2 s
thirdweb (cjs) 110.84 KB (0%) 2.3 s (0%) 486 ms (+27.6% 🔺) 2.8 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 10 ms (-33.76% 🔽) 122 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 11 ms (+299.48% 🔺) 21 ms
thirdweb/react (minimal + tree-shaking) 19.07 KB (-0.07% 🔽) 382 ms (-0.07% 🔽) 114 ms (+51.43% 🔺) 495 ms

@joaquim-verges joaquim-verges force-pushed the fix_Handle_NFT_fetch_failures_gracefully_and_add_Treasure_chain branch from fa673f2 to ea23046 Compare December 17, 2024 09:09
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 17, 2024 09:09 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 17, 2024 09:09 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www December 17, 2024 09:09 Inactive
@joaquim-verges joaquim-verges merged commit bdb27e4 into main Dec 17, 2024
32 checks passed
@joaquim-verges joaquim-verges deleted the fix_Handle_NFT_fetch_failures_gracefully_and_add_Treasure_chain branch December 17, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ecosystem Portal Involves changes to the Ecosystem Portal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants