[DASH-601] Fix stretched ENS avatar image + Replace MediaRenderer with Image in WalletAddress component #5772

MananTank · 2024-12-17T13:37:41Z

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR focuses on enhancing the styling of various components in the dashboard application by adding the object-cover class to ensure images maintain their aspect ratio while fitting within their containers.

Detailed summary

In publisher-header.tsx, added object-cover to the className of an element.
In index.tsx, added object-cover to the className of an element.
In profile-header.tsx, added object-cover to the className of an element.
In wallet-address.tsx, replaced MediaRenderer with Img for better image handling and added object-cover to its className.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

linear · 2024-12-17T13:37:44Z

DASH-601 Fix stretched ENS avatar in various places

vercel · 2024-12-17T13:37:46Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 17, 2024 4:40pm

3 Skipped Deployments

Name	Status	Updated (UTC)
docs-v2	⬜️ Skipped (Inspect)	Dec 17, 2024 4:40pm
thirdweb_playground	⬜️ Skipped (Inspect)	Dec 17, 2024 4:40pm
wallet-ui	⬜️ Skipped (Inspect)	Dec 17, 2024 4:40pm

changeset-bot · 2024-12-17T13:37:46Z

⚠️ No Changeset found

Latest commit: ae7d5f2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

MananTank · 2024-12-17T13:37:57Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codecov · 2024-12-17T13:39:04Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.99%. Comparing base (123435b) to head (ae7d5f2).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5772   +/-   ##
=======================================
  Coverage   52.99%   52.99%           
=======================================
  Files        1102     1102           
  Lines       59107    59107           
  Branches     4809     4809           
=======================================
  Hits        31323    31323           
  Misses      27066    27066           
  Partials      718      718

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from 123435b
packages	`50.13% <ø> (ø)`

*This pull request uses carry forward flags. Click here to find out more.

github-actions · 2024-12-17T13:41:20Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	44.93 KB (0%)	899 ms (0%)	2.1 s (-4.6% 🔽)	3 s
thirdweb (cjs)	110.84 KB (0%)	2.3 s (0%)	4.9 s (-28.01% 🔽)	7.2 s
thirdweb (minimal + tree-shaking)	5.58 KB (0%)	112 ms (0%)	284 ms (+64.96% 🔺)	396 ms
thirdweb/chains (tree-shaking)	506 B (0%)	10 ms (0%)	203 ms (+282.34% 🔺)	213 ms
thirdweb/react (minimal + tree-shaking)	19.07 KB (0%)	382 ms (0%)	1.1 s (+58.36% 🔺)	1.4 s

graphite-app · 2024-12-17T16:19:13Z

Merge activity

Dec 17, 11:19 AM EST: A user added this pull request to the Graphite merge queue.
Dec 17, 11:40 AM EST: A user merged this pull request with the Graphite merge queue.

…h Image in WalletAddress component (#5772) ## Problem solved Short description of the bug fixed or feature added  --- ## PR-Codex overview This PR focuses on enhancing the styling of various components by adding the `object-cover` class to ensure images maintain their aspect ratio and cover the designated area appropriately. ### Detailed summary - Updated `className` in `publisher-header.tsx` to include `object-cover`. - Updated `className` in `index.tsx` to include `object-cover`. - Updated `className` in `profile-header.tsx` to include `object-cover`. - Replaced `MediaRenderer` with `Img` in `wallet-address.tsx` for avatar rendering, adding `object-cover` to its `className`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

vercel bot temporarily deployed to Preview – wallet-ui December 17, 2024 13:37 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground December 17, 2024 13:37 Inactive

vercel bot temporarily deployed to Preview – docs-v2 December 17, 2024 13:37 Inactive

MananTank marked this pull request as ready for review December 17, 2024 13:37

MananTank requested review from jakubkrehel, jnsdls and joaquim-verges as code owners December 17, 2024 13:37

github-actions bot assigned MananTank Dec 17, 2024

github-actions bot added the Dashboard Involves changes to the Dashboard. label Dec 17, 2024

vercel bot deployed to Preview – thirdweb-www December 17, 2024 13:47 View deployment

MananTank changed the title ~~[DASH-601] Fix stretched ENS avatar image + Remove MediaRenderer from WalletAddress component and use image directly~~ [DASH-601] Fix stretched ENS avatar image + Replace MediaRenderer with Image in WalletAddress component Dec 17, 2024

jnsdls approved these changes Dec 17, 2024

View reviewed changes

MananTank force-pushed the 12-17-_dash-601_fix_stretched_ens_avatar_image_remove_mediarenderer_from_walletaddress_component_and_use_image_directly branch from 11294b6 to ae7d5f2 Compare December 17, 2024 16:32

vercel bot temporarily deployed to Preview – thirdweb_playground December 17, 2024 16:32 Inactive

vercel bot temporarily deployed to Preview – docs-v2 December 17, 2024 16:32 Inactive

vercel bot temporarily deployed to Preview – wallet-ui December 17, 2024 16:32 Inactive

vercel bot deployed to Preview – thirdweb-www December 17, 2024 16:40 View deployment

graphite-app bot merged commit ae7d5f2 into main Dec 17, 2024
32 checks passed

graphite-app bot deleted the 12-17-_dash-601_fix_stretched_ens_avatar_image_remove_mediarenderer_from_walletaddress_component_and_use_image_directly branch December 17, 2024 16:40

vercel bot temporarily deployed to Production – wallet-ui December 17, 2024 16:40 Inactive

vercel bot temporarily deployed to Production – docs-v2 December 17, 2024 16:40 Inactive

vercel bot temporarily deployed to Production – thirdweb_playground December 17, 2024 16:40 Inactive

vercel bot deployed to Production – thirdweb-www December 17, 2024 16:49 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[DASH-601] Fix stretched ENS avatar image + Replace MediaRenderer with Image in WalletAddress component #5772

[DASH-601] Fix stretched ENS avatar image + Replace MediaRenderer with Image in WalletAddress component #5772

MananTank commented Dec 17, 2024 •

edited by pr-codex bot

Loading

Uh oh!

linear bot commented Dec 17, 2024

Uh oh!

vercel bot commented Dec 17, 2024 •

edited

Loading

Uh oh!

changeset-bot bot commented Dec 17, 2024 •

edited

Loading

Uh oh!

MananTank commented Dec 17, 2024 •

edited

Loading

Uh oh!

codecov bot commented Dec 17, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Dec 17, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Dec 17, 2024 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[DASH-601] Fix stretched ENS avatar image + Replace MediaRenderer with Image in WalletAddress component #5772

[DASH-601] Fix stretched ENS avatar image + Replace MediaRenderer with Image in WalletAddress component #5772

Conversation

MananTank commented Dec 17, 2024 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem solved

PR-Codex overview

Detailed summary

Uh oh!

linear bot commented Dec 17, 2024

Uh oh!

vercel bot commented Dec 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Dec 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

MananTank commented Dec 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codecov bot commented Dec 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Dec 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

graphite-app bot commented Dec 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MananTank commented Dec 17, 2024 •

edited by pr-codex bot

Loading

vercel bot commented Dec 17, 2024 •

edited

Loading

changeset-bot bot commented Dec 17, 2024 •

edited

Loading

MananTank commented Dec 17, 2024 •

edited

Loading

codecov bot commented Dec 17, 2024 •

edited

Loading

github-actions bot commented Dec 17, 2024 •

edited

Loading

graphite-app bot commented Dec 17, 2024 •

edited

Loading