Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Dec 17, 2024

Problem solved

DASH-540

  • on the chat page -> move the container 1 level down - so the chat can be scrolled from the corner of the page as well
  • reduce container max-width for the history page to 800px to match it with landing page
  • stop the auto scroll if user interacts with chat UI
  • custom 404 page for the nebula subdomain
  • remove the announcement banner from the 404 pages ( this affects entire dashboard)
  • fix empty title in chat history page
  • fix overflow in chat history page on mobile when there's a long text without a whitespace

PR-Codex overview

This PR focuses on enhancing the user experience in the Nebula application by introducing an auto-scroll feature in chat components, improving layout styles, and adding a custom NotFound page.

Detailed summary

  • Added auto-scroll functionality to chat components.
  • Modified layout styles in ChatHistoryPage.tsx for better spacing.
  • Introduced a new NebulaNotFound component for handling 404 errors.
  • Updated Chats component to support auto-scroll state management.
  • Enhanced session card display with improved title handling.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Dec 17, 2024

@changeset-bot
Copy link

changeset-bot bot commented Dec 17, 2024

⚠️ No Changeset found

Latest commit: 69990ab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 8:37pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Dec 17, 2024 8:37pm
thirdweb_playground ⬜️ Skipped (Inspect) Dec 17, 2024 8:37pm
wallet-ui ⬜️ Skipped (Inspect) Dec 17, 2024 8:37pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 December 17, 2024 19:26 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 17, 2024 19:26 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 17, 2024 19:26 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Dec 17, 2024
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank marked this pull request as ready for review December 17, 2024 19:28
@codecov
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.99%. Comparing base (d8b4e09) to head (69990ab).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5777   +/-   ##
=======================================
  Coverage   52.99%   52.99%           
=======================================
  Files        1102     1102           
  Lines       59107    59107           
  Branches     4809     4809           
=======================================
  Hits        31323    31323           
  Misses      27066    27066           
  Partials      718      718           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from d8b4e09
packages 50.13% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 17, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.93 KB (0%) 899 ms (0%) 450 ms (+10.56% 🔺) 1.4 s
thirdweb (cjs) 110.84 KB (0%) 2.3 s (0%) 916 ms (+11.73% 🔺) 3.2 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 31 ms (-10.1% 🔽) 143 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 6 ms (-48% 🔽) 16 ms
thirdweb/react (minimal + tree-shaking) 19.07 KB (0%) 382 ms (0%) 187 ms (+81.16% 🔺) 569 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 17, 2024

Merge activity

## Problem solved

DASH-540

* on the chat page -> move the container 1 level down - so the chat can be scrolled from the corner of the page as well
* reduce container max-width for the history page to 800px to match it with landing page
* stop the auto scroll if user interacts with chat UI
* custom 404 page for the nebula subdomain
* remove the announcement banner from the 404 pages ( this affects entire dashboard)
* fix empty title in chat history page
* fix overflow in chat history page on mobile when there's a long text without a whitespace

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on enhancing the chat functionality and user experience in the `Nebula` application. It introduces auto-scrolling features, improves layout styling, and adds a new `404 Not Found` page.

### Detailed summary
- Added auto-scrolling feature to `Chats` component.
- Introduced `setEnableAutoScroll` function to manage scrolling behavior.
- Enhanced styling in `ChatHistoryPage` and `SessionCard`.
- Implemented a new `NebulaNotFound` component with a user-friendly 404 message.
- Updated `ChatPageContent` to utilize the new auto-scroll functionality.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@jnsdls jnsdls force-pushed the 12-18-_dash-540_nebula_-_various_ui_improvements branch from 3ce2a71 to 69990ab Compare December 17, 2024 20:29
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 17, 2024 20:29 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 17, 2024 20:29 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 17, 2024 20:29 Inactive
@graphite-app graphite-app bot merged commit 69990ab into main Dec 17, 2024
32 checks passed
@graphite-app graphite-app bot deleted the 12-18-_dash-540_nebula_-_various_ui_improvements branch December 17, 2024 20:37
@vercel vercel bot temporarily deployed to Production – wallet-ui December 17, 2024 20:37 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground December 17, 2024 20:37 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 December 17, 2024 20:37 Inactive
joaquim-verges pushed a commit that referenced this pull request Dec 17, 2024
## Problem solved

DASH-540

* on the chat page -> move the container 1 level down - so the chat can be scrolled from the corner of the page as well
* reduce container max-width for the history page to 800px to match it with landing page
* stop the auto scroll if user interacts with chat UI
* custom 404 page for the nebula subdomain
* remove the announcement banner from the 404 pages ( this affects entire dashboard)
* fix empty title in chat history page
* fix overflow in chat history page on mobile when there's a long text without a whitespace

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on enhancing the chat functionality and user experience in the `Nebula` application. It introduces auto-scrolling features, improves layout styling, and adds a new `404 Not Found` page.

### Detailed summary
- Added auto-scrolling feature to `Chats` component.
- Introduced `setEnableAutoScroll` function to manage scrolling behavior.
- Enhanced styling in `ChatHistoryPage` and `SessionCard`.
- Implemented a new `NebulaNotFound` component with a user-friendly 404 message.
- Updated `ChatPageContent` to utilize the new auto-scroll functionality.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
joaquim-verges pushed a commit that referenced this pull request Dec 18, 2024
DASH-540

* on the chat page -> move the container 1 level down - so the chat can be scrolled from the corner of the page as well
* reduce container max-width for the history page to 800px to match it with landing page
* stop the auto scroll if user interacts with chat UI
* custom 404 page for the nebula subdomain
* remove the announcement banner from the 404 pages ( this affects entire dashboard)
* fix empty title in chat history page
* fix overflow in chat history page on mobile when there's a long text without a whitespace

<!-- start pr-codex -->

---

This PR focuses on enhancing the chat functionality and user experience in the `Nebula` application. It introduces auto-scrolling features, improves layout styling, and adds a new `404 Not Found` page.

- Added auto-scrolling feature to `Chats` component.
- Introduced `setEnableAutoScroll` function to manage scrolling behavior.
- Enhanced styling in `ChatHistoryPage` and `SessionCard`.
- Implemented a new `NebulaNotFound` component with a user-friendly 404 message.
- Updated `ChatPageContent` to utilize the new auto-scroll functionality.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants