Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Dec 19, 2024

closes: CORE-659


PR-Codex overview

This PR focuses on the removal of several files related to templates and the introduction of new routing for template-related pages in the dashboard. It also modifies the LinkButtonProps interface and updates redirects.

Detailed summary

  • Deleted files:
    • apps/dashboard/src/pages/templates.tsx
    • apps/dashboard/src/pages/template/[id].tsx
    • apps/dashboard/src/components/shared/GeneralCta.tsx
    • apps/dashboard/src/components/product-pages/common/ProductButton.tsx
    • apps/dashboard/src/components/homepage/sections/GetStartedSection.tsx
    • apps/dashboard/src/components/product-pages/homepage/HomepageSection.tsx
  • Updated apps/dashboard/framer-rewrites.js to include new template routes.
  • Modified LinkButtonProps interface in apps/dashboard/src/tw-components/button.tsx by removing the export keyword.
  • Added a redirect rule for /template/:slug to /templates/:slug in apps/dashboard/src/redirects.js.
  • Removed template-related constants in apps/dashboard/src/page-id.ts.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Dec 19, 2024

@changeset-bot
Copy link

changeset-bot bot commented Dec 19, 2024

⚠️ No Changeset found

Latest commit: fa26eef

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 7:23pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Dec 19, 2024 7:23pm
thirdweb_playground ⬜️ Skipped (Inspect) Dec 19, 2024 7:23pm
wallet-ui ⬜️ Skipped (Inspect) Dec 19, 2024 7:23pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui December 19, 2024 19:09 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 19, 2024 19:09 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 19, 2024 19:09 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Dec 19, 2024
@jnsdls jnsdls marked this pull request as ready for review December 19, 2024 19:10
@jnsdls jnsdls requested review from a team and jakubkrehel as code owners December 19, 2024 19:10
@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.02 KB (0%) 901 ms (0%) 3 s (-5.87% 🔽) 3.9 s
thirdweb (cjs) 110.76 KB (0%) 2.3 s (0%) 6 s (-2.55% 🔽) 8.2 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 232 ms (-9.84% 🔽) 343 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 188 ms (-14.18% 🔽) 198 ms
thirdweb/react (minimal + tree-shaking) 19.1 KB (0%) 383 ms (0%) 1.1 s (+83.42% 🔺) 1.5 s

@codecov
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.34%. Comparing base (7c40fda) to head (fa26eef).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5808   +/-   ##
=======================================
  Coverage   53.34%   53.34%           
=======================================
  Files        1101     1101           
  Lines       59124    59124           
  Branches     4825     4825           
=======================================
  Hits        31541    31541           
  Misses      26864    26864           
  Partials      719      719           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 7c40fda
packages 50.56% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 19, 2024

Merge activity

@jnsdls jnsdls force-pushed the 12-19-core-659_-_rewrite_templates_to_framer branch from a4c08ae to fa26eef Compare December 19, 2024 19:20
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 19, 2024 19:20 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 19, 2024 19:20 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 19, 2024 19:20 Inactive
@graphite-app graphite-app bot merged commit fa26eef into main Dec 19, 2024
32 checks passed
@graphite-app graphite-app bot deleted the 12-19-core-659_-_rewrite_templates_to_framer branch December 19, 2024 19:27
@vercel vercel bot temporarily deployed to Production – docs-v2 December 19, 2024 19:27 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground December 19, 2024 19:27 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui December 19, 2024 19:27 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants