-
Notifications
You must be signed in to change notification settings - Fork 619
[TOOL-2814] Fix custom factory publish form #5819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5819 +/- ##
=======================================
Coverage 53.34% 53.34%
=======================================
Files 1101 1101
Lines 59124 59124
Branches 4825 4825
=======================================
Hits 31541 31541
Misses 26864 26864
Partials 719 719
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
Merge activity
|
TOOL-2814
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR refactors the `useCustomFactoryAbi` function in `hooks.ts` to improve contract handling and query logic. It changes how the contract is retrieved and updates the query's enabled condition.
### Detailed summary
- Changed import statements for `ThirdwebContract` and `getContract`.
- Refactored the `contract` retrieval logic to be more concise.
- Updated `queryKey` to include `contractAddress` and `chainId`.
- Modified the `enabled` condition to check for `contractAddress` and `chainId`.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
b767f93 to
5f8e570
Compare
TOOL-2814
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR refactors the
useCustomFactoryAbifunction in thehooks.tsfile to improve contract retrieval logic and enhance type imports.Detailed summary
ThirdwebContractto a type-only import.getContractandresolveContractAbito a single import statement.useMemologic to directly handle contract retrieval within theuseQuery.contractAddressandchainId.enabledcondition to check for bothcontractAddressandchainId.