Skip to content

Conversation

@Pricstas
Copy link
Contributor

@Pricstas Pricstas commented Dec 23, 2024

This pull request addresses various typos and minor inconsistencies in the documentation across multiple files.
The changes improve readability and ensure consistent terminology throughout the project.


PR-Codex overview

This PR primarily focuses on correcting minor grammatical issues and enhancing clarity in documentation across various files related to the thirdweb project.

Detailed summary

  • Updated comments in ethers6.ts for clarity on Signer and Wallet conversion.
  • Revised phrases in page.mdx files for grammatical accuracy.
  • Ensured consistency in describing modules across multiple ERC token contracts.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Signed-off-by: Tristav <124001124+Pricstas@users.noreply.github.com>
Signed-off-by: Tristav <124001124+Pricstas@users.noreply.github.com>
Signed-off-by: Tristav <124001124+Pricstas@users.noreply.github.com>
Signed-off-by: Tristav <124001124+Pricstas@users.noreply.github.com>
Signed-off-by: Tristav <124001124+Pricstas@users.noreply.github.com>
Signed-off-by: Tristav <124001124+Pricstas@users.noreply.github.com>
Signed-off-by: Tristav <124001124+Pricstas@users.noreply.github.com>
Signed-off-by: Tristav <124001124+Pricstas@users.noreply.github.com>
Signed-off-by: Tristav <124001124+Pricstas@users.noreply.github.com>
Signed-off-by: Tristav <124001124+Pricstas@users.noreply.github.com>
Signed-off-by: Tristav <124001124+Pricstas@users.noreply.github.com>
Signed-off-by: Tristav <124001124+Pricstas@users.noreply.github.com>
@Pricstas Pricstas requested review from a team and jakubkrehel as code owners December 23, 2024 13:06
@changeset-bot
Copy link

changeset-bot bot commented Dec 23, 2024

⚠️ No Changeset found

Latest commit: e9a90d0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 23, 2024

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@vercel
Copy link

vercel bot commented Dec 23, 2024

@Pricstas is attempting to deploy a commit to the thirdweb Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added Portal Involves changes to the Portal (docs) codebase. packages SDK Involves changes to the thirdweb SDK labels Dec 23, 2024
Copy link
Contributor

@kien-ngo kien-ngo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good. Thanks for contributing!!

@vercel
Copy link

vercel bot commented Dec 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2024 11:12pm

@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Dec 23, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 23, 2024

Merge activity

  • Dec 23, 10:39 PM UTC: @gregfromstl we removed the merge queue label because we could not find a Graphite account associated with your GitHub profile.

You must have a Graphite account in order to use the merge queue. Create an account and try again using this link

@graphite-app graphite-app bot removed the merge-queue Adds the pull request to Graphite's merge queue. label Dec 23, 2024
@gregfromstl gregfromstl merged commit a83fee6 into thirdweb-dev:main Dec 23, 2024
24 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages Portal Involves changes to the Portal (docs) codebase. SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants