-
Notifications
You must be signed in to change notification settings - Fork 620
[Docs] .NET Fix LoginWithOtp Example #5843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Merge activity
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5843 +/- ##
=======================================
Coverage 54.53% 54.53%
=======================================
Files 1105 1105
Lines 59332 59332
Branches 4924 4924
=======================================
Hits 32354 32354
Misses 26258 26258
Partials 720 720
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
Closes TOOL-2863
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on simplifying the OTP login process in the `InAppWallet` by removing the `canRetry` variable and related conditional logic, providing a more straightforward approach for handling OTP submissions.
### Detailed summary
- Removed the `canRetry` variable from the `LoginWithOtp` method calls.
- Simplified the OTP login logic by eliminating the retry checks.
- Added comments to indicate where to implement error handling and retries if needed.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
853e170 to
1556615
Compare
Closes TOOL-2863
PR-Codex overview
This PR focuses on simplifying the OTP login process in the
in-app-walletfunctionality by removing thecanRetryvariable and associated logic, encouraging a retry mechanism through exception handling instead.Detailed summary
canRetryfromLoginWithOtpmethod calls.