-
Notifications
You must be signed in to change notification settings - Fork 619
[TOOL-2995]: Fix Engine Contract Subscription UI issue with checkboxes #5920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TOOL-2995]: Fix Engine Contract Subscription UI issue with checkboxes #5920
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
size-limit report 📦
|
7fe6e2e to
9217447
Compare
Merge activity
|
9217447 to
edeef25
Compare
edeef25 to
ae9419b
Compare
ae9419b to
17b11dd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5920 +/- ##
=======================================
Coverage 54.83% 54.83%
=======================================
Files 1141 1141
Lines 60894 60894
Branches 5126 5126
=======================================
Hits 33390 33390
Misses 26779 26779
Partials 725 725
*This pull request uses carry forward flags. Click here to find out more. |
#5920) --- title: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" --- If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on updating the checkbox components in the application to improve their functionality and layout by integrating `CheckboxWithLabel` for better labeling and interaction management. ### Detailed summary - Replaced direct usage of `Checkbox` with `CheckboxWithLabel` in `batch-lazy-mint.tsx` for the `shuffle` option. - Updated event handling for `processEventLogs` checkbox in `add-contract-subscription-button.tsx` to use `CheckboxWithLabel`. - Changed `processTransactionReceipts` checkbox to use `CheckboxWithLabel`. - Refactored filter selection to use `CheckboxWithLabel` for better UI consistency. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
17b11dd to
c1bfa11
Compare
#5920) --- title: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" --- If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on enhancing the user interface for checkbox components in the `batch-lazy-mint.tsx` and `add-contract-subscription-button.tsx` files. It improves the handling of checkbox states and integrates labels more effectively. ### Detailed summary - In `batch-lazy-mint.tsx`, replaced `Checkbox` with a more integrated `CheckboxWithLabel`. - Updated checkbox handling to use `form.watch` and `form.setValue` for state management. - In `add-contract-subscription-button.tsx`, converted checkboxes to use `CheckboxWithLabel` for better labeling. - Simplified checkbox state handling by removing `form.register`. - Adjusted label elements from `<Text>` to `<span>` for consistency. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
c1bfa11 to
ed0d215
Compare

title: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"
If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):
Notes for the reviewer
Anything important to call out? Be sure to also clarify these in your comments.
How to test
Unit tests, playground, etc.
PR-Codex overview
This PR focuses on improving the user interface for batch uploads and contract subscriptions by replacing standard
Checkboxcomponents withCheckboxWithLabelcomponents, enhancing state management, and ensuring better readability.Detailed summary
CheckboxwithCheckboxWithLabelinbatch-lazy-mint.tsx.checkedandonCheckedChangeproperties to useform.watchandform.setValue.Texttospanfor consistency inadd-contract-subscription-button.tsx.CheckboxGroupin favor of individualCheckboxWithLabelcomponents for filtering options.