Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Jan 9, 2025


title: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

How to test

Unit tests, playground, etc.


PR-Codex overview

This PR focuses on improving the user interface for batch uploads and contract subscriptions by replacing standard Checkbox components with CheckboxWithLabel components, enhancing state management, and ensuring better readability.

Detailed summary

  • Replaced standard Checkbox with CheckboxWithLabel in batch-lazy-mint.tsx.
  • Updated checked and onCheckedChange properties to use form.watch and form.setValue.
  • Modified text elements from Text to span for consistency in add-contract-subscription-button.tsx.
  • Removed CheckboxGroup in favor of individual CheckboxWithLabel components for filtering options.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Jan 9, 2025

@changeset-bot
Copy link

changeset-bot bot commented Jan 9, 2025

⚠️ No Changeset found

Latest commit: ed0d215

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 9:28pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jan 9, 2025 9:28pm
thirdweb_playground ⬜️ Skipped (Inspect) Jan 9, 2025 9:28pm
wallet-ui ⬜️ Skipped (Inspect) Jan 9, 2025 9:28pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 January 9, 2025 15:49 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 9, 2025 15:49 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 9, 2025 15:49 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jan 9, 2025
@MananTank MananTank marked this pull request as ready for review January 9, 2025 15:50
@MananTank MananTank requested review from a team as code owners January 9, 2025 15:50
Copy link
Member Author

MananTank commented Jan 9, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.65 KB (0%) 913 ms (0%) 441 ms (-2.77% 🔽) 1.4 s
thirdweb (cjs) 115.43 KB (0%) 2.4 s (0%) 1.3 s (+3.77% 🔺) 3.6 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 132 ms (+171.71% 🔺) 244 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 26 ms (+19.48% 🔺) 36 ms
thirdweb/react (minimal + tree-shaking) 19.21 KB (0%) 385 ms (0%) 151 ms (+67.86% 🔺) 535 ms

@MananTank MananTank marked this pull request as draft January 9, 2025 15:54
@MananTank MananTank force-pushed the 01-09-_tool-2995_fix_engine_contract_subscription_ui_issue_with_checkboxes branch from 7fe6e2e to 9217447 Compare January 9, 2025 15:56
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 9, 2025 15:56 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 9, 2025 15:56 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 9, 2025 15:56 Inactive
@MananTank MananTank marked this pull request as ready for review January 9, 2025 15:57
@MananTank MananTank added the hotfix This pull request should be prioritized in the merge queue. label Jan 9, 2025 — with Graphite App
Copy link
Member Author

MananTank commented Jan 9, 2025

Merge activity

@MananTank MananTank added the Bug Something isn't working as intended in a provided reproduction. label Jan 9, 2025 — with Graphite App
@MananTank MananTank removed the Bug Something isn't working as intended in a provided reproduction. label Jan 9, 2025
@MananTank MananTank force-pushed the 01-09-_tool-2995_fix_engine_contract_subscription_ui_issue_with_checkboxes branch from 9217447 to edeef25 Compare January 9, 2025 16:36
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 9, 2025 16:36 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 9, 2025 16:36 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 9, 2025 16:36 Inactive
@MananTank MananTank force-pushed the 01-09-_tool-2995_fix_engine_contract_subscription_ui_issue_with_checkboxes branch from edeef25 to ae9419b Compare January 9, 2025 16:41
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 9, 2025 16:41 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 9, 2025 16:41 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 9, 2025 16:41 Inactive
@MananTank MananTank force-pushed the 01-09-_tool-2995_fix_engine_contract_subscription_ui_issue_with_checkboxes branch from ae9419b to 17b11dd Compare January 9, 2025 16:47
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 9, 2025 16:47 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 9, 2025 16:47 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 9, 2025 16:47 Inactive
@codecov
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.83%. Comparing base (c5c6f9d) to head (ed0d215).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5920   +/-   ##
=======================================
  Coverage   54.83%   54.83%           
=======================================
  Files        1141     1141           
  Lines       60894    60894           
  Branches     5126     5126           
=======================================
  Hits        33390    33390           
  Misses      26779    26779           
  Partials      725      725           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from c5c6f9d
packages 52.47% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

MananTank added a commit that referenced this pull request Jan 9, 2025
#5920)

---
title: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"
---

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer
Anything important to call out? Be sure to also clarify these in your comments.

## How to test
Unit tests, playground, etc.

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating the checkbox components in the application to improve their functionality and layout by integrating `CheckboxWithLabel` for better labeling and interaction management.

### Detailed summary
- Replaced direct usage of `Checkbox` with `CheckboxWithLabel` in `batch-lazy-mint.tsx` for the `shuffle` option.
- Updated event handling for `processEventLogs` checkbox in `add-contract-subscription-button.tsx` to use `CheckboxWithLabel`.
- Changed `processTransactionReceipts` checkbox to use `CheckboxWithLabel`.
- Refactored filter selection to use `CheckboxWithLabel` for better UI consistency.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 01-09-_tool-2995_fix_engine_contract_subscription_ui_issue_with_checkboxes branch from 17b11dd to c1bfa11 Compare January 9, 2025 19:16
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 9, 2025 19:16 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 9, 2025 19:16 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 9, 2025 19:16 Inactive
@graphite-app graphite-app bot removed the hotfix This pull request should be prioritized in the merge queue. label Jan 9, 2025
#5920)

---
title: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"
---

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer
Anything important to call out? Be sure to also clarify these in your comments.

## How to test
Unit tests, playground, etc.

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on enhancing the user interface for checkbox components in the `batch-lazy-mint.tsx` and `add-contract-subscription-button.tsx` files. It improves the handling of checkbox states and integrates labels more effectively.

### Detailed summary
- In `batch-lazy-mint.tsx`, replaced `Checkbox` with a more integrated `CheckboxWithLabel`.
- Updated checkbox handling to use `form.watch` and `form.setValue` for state management.
- In `add-contract-subscription-button.tsx`, converted checkboxes to use `CheckboxWithLabel` for better labeling.
- Simplified checkbox state handling by removing `form.register`.
- Adjusted label elements from `<Text>` to `<span>` for consistency.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 01-09-_tool-2995_fix_engine_contract_subscription_ui_issue_with_checkboxes branch from c1bfa11 to ed0d215 Compare January 9, 2025 21:19
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 9, 2025 21:20 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 9, 2025 21:20 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 9, 2025 21:20 Inactive
@graphite-app graphite-app bot merged commit ed0d215 into main Jan 9, 2025
32 checks passed
@graphite-app graphite-app bot deleted the 01-09-_tool-2995_fix_engine_contract_subscription_ui_issue_with_checkboxes branch January 9, 2025 21:28
@vercel vercel bot temporarily deployed to Production – docs-v2 January 9, 2025 21:28 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground January 9, 2025 21:28 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui January 9, 2025 21:28 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants