[TOOL-2822]: Insight Playground: Move chain from subdomain to query param #5922

MananTank · 2025-01-09T21:42:17Z

PR-Codex overview

This PR focuses on modifying the handling of the chainId parameter by renaming it to chain, updating its usage in the BlueprintPlayground component, and adjusting its schema requirements.

Detailed summary

Changed the domain to use a simplified URL structure.
Renamed the parameter from chainId to chain.
Updated the parameter's input type from path to query.
Adjusted the ParameterSection component to reflect the new parameter name.
Added a fallback for parameter schema creation to default to z.string().

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel · 2025-01-09T21:42:20Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 9, 2025 10:02pm

3 Skipped Deployments

Name	Status	Updated (UTC)
docs-v2	⬜️ Skipped (Inspect)	Jan 9, 2025 10:02pm
thirdweb_playground	⬜️ Skipped (Inspect)	Jan 9, 2025 10:02pm
wallet-ui	⬜️ Skipped (Inspect)	Jan 9, 2025 10:02pm

linear · 2025-01-09T21:42:20Z

TOOL-2822 Change playground to use query parameter for chainId instead of putting it in domain

changeset-bot · 2025-01-09T21:42:21Z

⚠️ No Changeset found

Latest commit: 5866088

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

MananTank · 2025-01-09T21:42:41Z

[TOOL-2822]: Insight Playground: Move chain from subdomain to query param #5922 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codecov · 2025-01-09T21:43:30Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.83%. Comparing base (ed0d215) to head (5866088).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5922   +/-   ##
=======================================
  Coverage   54.83%   54.83%           
=======================================
  Files        1141     1141           
  Lines       60894    60894           
  Branches     5126     5126           
=======================================
  Hits        33390    33390           
  Misses      26779    26779           
  Partials      725      725

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from ed0d215
packages	`52.47% <ø> (ø)`

*This pull request uses carry forward flags. Click here to find out more.

github-actions · 2025-01-09T21:46:02Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	45.65 KB (0%)	913 ms (0%)	2.8 s (+11.25% 🔺)	3.7 s
thirdweb (cjs)	115.43 KB (0%)	2.4 s (0%)	6.7 s (+7.75% 🔺)	9 s
thirdweb (minimal + tree-shaking)	5.59 KB (0%)	112 ms (0%)	314 ms (-10.69% 🔽)	426 ms
thirdweb/chains (tree-shaking)	506 B (0%)	10 ms (0%)	254 ms (+617.31% 🔺)	264 ms
thirdweb/react (minimal + tree-shaking)	19.21 KB (0%)	385 ms (0%)	749 ms (-11.28% 🔽)	1.2 s

graphite-app · 2025-01-09T21:58:38Z

Merge activity

Jan 9, 4:58 PM EST: A user added this pull request to the Graphite merge queue.
Jan 9, 5:04 PM EST: A user merged this pull request with the Graphite merge queue.

…aram (#5922)  ## PR-Codex overview This PR focuses on modifying the handling of a parameter in the `BlueprintPlayground` component, changing its name from `chainId` to `chain`, and updating its usage throughout the codebase. ### Detailed summary - Changed the `domain` URL format to remove `chainId`. - Updated the parameter name from `chainId` to `chain` in `modifyParametersForPlayground`. - Adjusted the parameter handling in `ParameterSection` to reflect the new name. - Updated the schema creation to default to `z.string()` for parameters without a schema. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

vercel bot temporarily deployed to Preview – thirdweb_playground January 9, 2025 21:42 Inactive

vercel bot temporarily deployed to Preview – wallet-ui January 9, 2025 21:42 Inactive

vercel bot temporarily deployed to Preview – docs-v2 January 9, 2025 21:42 Inactive

github-actions bot assigned MananTank Jan 9, 2025

github-actions bot added the Dashboard Involves changes to the Dashboard. label Jan 9, 2025

MananTank marked this pull request as ready for review January 9, 2025 21:42

MananTank requested review from a team as code owners January 9, 2025 21:42

joaquim-verges approved these changes Jan 9, 2025

View reviewed changes

MananTank force-pushed the 01-10-_tool-2822_insight_playground_move_chain_from_subdomain_to_query_param branch from 22808d4 to fe387d5 Compare January 9, 2025 21:48

vercel bot temporarily deployed to Preview – docs-v2 January 9, 2025 21:48 Inactive

vercel bot temporarily deployed to Preview – wallet-ui January 9, 2025 21:48 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground January 9, 2025 21:48 Inactive

vercel bot deployed to Preview – thirdweb-www January 9, 2025 21:58 View deployment

MananTank force-pushed the 01-10-_tool-2822_insight_playground_move_chain_from_subdomain_to_query_param branch from fe387d5 to 5866088 Compare January 9, 2025 21:59

vercel bot temporarily deployed to Preview – wallet-ui January 9, 2025 21:59 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground January 9, 2025 21:59 Inactive

vercel bot temporarily deployed to Preview – docs-v2 January 9, 2025 21:59 Inactive

vercel bot deployed to Preview – thirdweb-www January 9, 2025 22:02 View deployment

graphite-app bot merged commit 5866088 into main Jan 9, 2025
32 checks passed

graphite-app bot deleted the 01-10-_tool-2822_insight_playground_move_chain_from_subdomain_to_query_param branch January 9, 2025 22:04

vercel bot temporarily deployed to Production – thirdweb_playground January 9, 2025 22:04 Inactive

vercel bot temporarily deployed to Production – wallet-ui January 9, 2025 22:04 Inactive

vercel bot temporarily deployed to Production – docs-v2 January 9, 2025 22:04 Inactive

vercel bot deployed to Production – thirdweb-www January 9, 2025 22:13 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[TOOL-2822]: Insight Playground: Move chain from subdomain to query param #5922

[TOOL-2822]: Insight Playground: Move chain from subdomain to query param #5922

Uh oh!

MananTank commented Jan 9, 2025 •

edited by pr-codex bot

Loading

Uh oh!

vercel bot commented Jan 9, 2025 •

edited

Loading

Uh oh!

linear bot commented Jan 9, 2025

Uh oh!

changeset-bot bot commented Jan 9, 2025 •

edited

Loading

Uh oh!

MananTank commented Jan 9, 2025

Uh oh!

codecov bot commented Jan 9, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jan 9, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Jan 9, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[TOOL-2822]: Insight Playground: Move chain from subdomain to query param #5922

[TOOL-2822]: Insight Playground: Move chain from subdomain to query param #5922

Uh oh!

Conversation

MananTank commented Jan 9, 2025 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR-Codex overview

Detailed summary

Uh oh!

vercel bot commented Jan 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linear bot commented Jan 9, 2025

Uh oh!

changeset-bot bot commented Jan 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

MananTank commented Jan 9, 2025

How to use the Graphite Merge Queue

Uh oh!

codecov bot commented Jan 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Jan 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

graphite-app bot commented Jan 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MananTank commented Jan 9, 2025 •

edited by pr-codex bot

Loading

vercel bot commented Jan 9, 2025 •

edited

Loading

changeset-bot bot commented Jan 9, 2025 •

edited

Loading

codecov bot commented Jan 9, 2025 •

edited

Loading

github-actions bot commented Jan 9, 2025 •

edited

Loading

graphite-app bot commented Jan 9, 2025 •

edited

Loading