Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Jan 15, 2025


title: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

How to test

Unit tests, playground, etc.


PR-Codex overview

This PR modifies test descriptions for execute and chat functions in the Nebula module to be skipped unless a specific environment variable (TW_SECRET_KEY) is set. This change is aimed at controlling the execution of these tests manually.

Detailed summary

  • Updated describe for execute test to describe.runIf(process.env.TW_SECRET_KEY).skip("execute", ...).
  • Updated describe for chat test to describe.runIf(process.env.TW_SECRET_KEY).skip("chat", ...).

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Jan 15, 2025

⚠️ No Changeset found

Latest commit: 225a9b7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 11:03pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 11:03pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 11:03pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 11:03pm

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Jan 15, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges marked this pull request as ready for review January 15, 2025 22:55
@joaquim-verges joaquim-verges requested review from a team as code owners January 15, 2025 22:55
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.68 KB (0%) 934 ms (0%) 1.5 s (+30.09% 🔺) 2.4 s
thirdweb (cjs) 116.72 KB (0%) 2.4 s (0%) 3.5 s (+1.37% 🔺) 5.9 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 254 ms (+17.28% 🔺) 366 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 67 ms (+171.43% 🔺) 77 ms
thirdweb/react (minimal + tree-shaking) 19.24 KB (0%) 385 ms (0%) 309 ms (-36.9% 🔽) 694 ms

@joaquim-verges joaquim-verges merged commit 51a28c4 into main Jan 15, 2025
30 of 33 checks passed
@joaquim-verges joaquim-verges deleted the _SDK_test_Skip_Nebula_AI_tests_by_default branch January 15, 2025 23:11
@codecov
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.82%. Comparing base (d1c03b0) to head (225a9b7).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5961      +/-   ##
==========================================
- Coverage   54.89%   54.82%   -0.08%     
==========================================
  Files        1146     1150       +4     
  Lines       61108    61194      +86     
  Branches     5154     5155       +1     
==========================================
+ Hits        33548    33549       +1     
- Misses      26832    26918      +86     
+ Partials      728      727       -1     
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from d1c03b0
packages 52.47% <ø> (-0.09%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 3 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants