-
Notifications
You must be signed in to change notification settings - Fork 618
[TOOL-3110] Dashboard: Engine pages cleanup: Fetch engine info on server + Use layout #5968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TOOL-3110] Dashboard: Engine pages cleanup: Fetch engine info on server + Use layout #5968
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5968 +/- ##
=======================================
Coverage 54.81% 54.81%
=======================================
Files 1150 1150
Lines 61195 61195
Branches 5153 5153
=======================================
Hits 33545 33545
Misses 26923 26923
Partials 727 727
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
Merge activity
|
…ver + Use layout (#5968) Engine pages were in a weird "pages router" type of state - Its now properly migrated to app router * Common skeleton is moved to layout * engine instances are fetched on server
2bde7fd to
53fdb2b
Compare
…ver + Use layout (#5968) Engine pages were in a weird "pages router" type of state - Its now properly migrated to app router * Common skeleton is moved to layout * engine instances are fetched on server <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on refactoring and enhancing the engine instance management in the application. It removes obsolete files, improves error handling, and introduces new utility functions for fetching engine instances and permissions. ### Detailed summary - Deleted multiple obsolete `.tsx` files related to engine instance management. - Improved error handling in engine import functionality. - Added `getEngineAccessPermission` and `getEngineInstances` utility functions. - Refactored components to utilize new utility functions for fetching engine data. - Enhanced the layout and error handling in the engine instance pages. - Updated components to use consistent instance data and permissions checks. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
53fdb2b to
fe3f24e
Compare

Engine pages were in a weird "pages router" type of state - Its now properly migrated to app router
PR-Codex overview
This PR focuses on refactoring the
enginemodule, enhancing error handling, and improving the structure of engine instance pages. It removes unused components and consolidates logic for better maintainability.Detailed summary
.tsxfiles related to engine instances.getEngineAccessPermissionandgetEngineInstancesutility functions.engineInstancePageHandler.