Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Jan 16, 2025

Engine pages were in a weird "pages router" type of state - Its now properly migrated to app router

  • Common skeleton is moved to layout
  • engine instances are fetched on server

PR-Codex overview

This PR focuses on refactoring the engine module, enhancing error handling, and improving the structure of engine instance pages. It removes unused components and consolidates logic for better maintainability.

Detailed summary

  • Deleted several unused .tsx files related to engine instances.
  • Improved error handling in the engine import process.
  • Added getEngineAccessPermission and getEngineInstances utility functions.
  • Refactored engine instance page components to use engineInstancePageHandler.
  • Updated the structure of engine instance pages for better readability and maintainability.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Jan 16, 2025

@changeset-bot
Copy link

changeset-bot bot commented Jan 16, 2025

⚠️ No Changeset found

Latest commit: fe3f24e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 8:46pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jan 16, 2025 8:46pm
thirdweb_playground ⬜️ Skipped (Inspect) Jan 16, 2025 8:46pm
wallet-ui ⬜️ Skipped (Inspect) Jan 16, 2025 8:46pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 January 16, 2025 19:39 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 16, 2025 19:39 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 16, 2025 19:39 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jan 16, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank marked this pull request as ready for review January 16, 2025 19:39
@MananTank MananTank requested review from a team as code owners January 16, 2025 19:39
@MananTank MananTank changed the title [TOOL-3110] Dashboard: Engine pages cleanup: Fetch engine info on server + Use layout [TOOL-3110] Dashboard: Engine pages cleanup: Fetch/a engine info on server + Use layout Jan 16, 2025
@MananTank MananTank changed the title [TOOL-3110] Dashboard: Engine pages cleanup: Fetch/a engine info on server + Use layout [TOOL-3110] Dashboard: Engine pages cleanup: Fetch engine info on server + Use layout Jan 16, 2025
@codecov
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.81%. Comparing base (9f55100) to head (fe3f24e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5968   +/-   ##
=======================================
  Coverage   54.81%   54.81%           
=======================================
  Files        1150     1150           
  Lines       61195    61195           
  Branches     5153     5153           
=======================================
  Hits        33545    33545           
  Misses      26923    26923           
  Partials      727      727           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 9f55100
packages 52.46% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.66 KB (0%) 934 ms (0%) 3.2 s (+3.07% 🔺) 4.1 s
thirdweb (cjs) 116.84 KB (0%) 2.4 s (0%) 6.3 s (-12.62% 🔽) 8.6 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 156 ms (-65.25% 🔽) 268 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 219 ms (+54.49% 🔺) 229 ms
thirdweb/react (minimal + tree-shaking) 19.24 KB (0%) 385 ms (0%) 689 ms (-20.09% 🔽) 1.1 s

@joaquim-verges joaquim-verges added the merge-queue Adds the pull request to Graphite's merge queue. label Jan 16, 2025
Copy link
Member

joaquim-verges commented Jan 16, 2025

Merge activity

  • Jan 16, 3:31 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 16, 3:31 PM EST: A user added this pull request to the Graphite merge queue.
  • Jan 16, 3:47 PM EST: A user merged this pull request with the Graphite merge queue.

joaquim-verges pushed a commit that referenced this pull request Jan 16, 2025
…ver + Use layout (#5968)

Engine pages were in a weird "pages router" type of state - Its now properly migrated to app router

* Common skeleton is moved to layout
* engine instances are fetched on server
@joaquim-verges joaquim-verges force-pushed the 01-17-_tool-3110_dashboard_engine_pages_cleanup_fetch_engine_info_on_server_use_layout branch from 2bde7fd to 53fdb2b Compare January 16, 2025 20:31
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 16, 2025 20:32 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 16, 2025 20:32 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 16, 2025 20:32 Inactive
…ver + Use layout (#5968)

Engine pages were in a weird "pages router" type of state - Its now properly migrated to app router

* Common skeleton is moved to layout
* engine instances are fetched on server

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on refactoring and enhancing the engine instance management in the application. It removes obsolete files, improves error handling, and introduces new utility functions for fetching engine instances and permissions.

### Detailed summary
- Deleted multiple obsolete `.tsx` files related to engine instance management.
- Improved error handling in engine import functionality.
- Added `getEngineAccessPermission` and `getEngineInstances` utility functions.
- Refactored components to utilize new utility functions for fetching engine data.
- Enhanced the layout and error handling in the engine instance pages.
- Updated components to use consistent instance data and permissions checks.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@joaquim-verges joaquim-verges force-pushed the 01-17-_tool-3110_dashboard_engine_pages_cleanup_fetch_engine_info_on_server_use_layout branch from 53fdb2b to fe3f24e Compare January 16, 2025 20:34
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 16, 2025 20:34 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 16, 2025 20:34 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 16, 2025 20:34 Inactive
@graphite-app graphite-app bot merged commit fe3f24e into main Jan 16, 2025
32 checks passed
@graphite-app graphite-app bot deleted the 01-17-_tool-3110_dashboard_engine_pages_cleanup_fetch_engine_info_on_server_use_layout branch January 16, 2025 20:47
@vercel vercel bot temporarily deployed to Production – docs-v2 January 16, 2025 20:47 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground January 16, 2025 20:47 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui January 16, 2025 20:47 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. merge-queue Adds the pull request to Graphite's merge queue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants