Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Jan 16, 2025


title: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

How to test

Unit tests, playground, etc.


PR-Codex overview

This PR focuses on updating the sidebar link groups and modifying documentation comments in various files, including the addition of new wallet-related tags and adjustments to existing documentation.

Detailed summary

  • In getSidebarLinkgroups.ts, added @account and @nebula tags to the sidebar group order and removed them from the previous list.
  • In autoConnect.ts, added @walletConnection to the documentation comment for the autoConnect function.
  • In get-claim-params.ts, changed @extension ERC1155 and @extension COMMON to @utils in the documentation comment for the getClaimParams function.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Jan 16, 2025

⚠️ No Changeset found

Latest commit: 39f8db0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 8:28pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 8:28pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 8:28pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 8:28pm

@github-actions github-actions bot added Portal Involves changes to the Portal (docs) codebase. packages SDK Involves changes to the thirdweb SDK labels Jan 16, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.66 KB (0%) 934 ms (0%) 3.5 s (-3.21% 🔽) 4.4 s
thirdweb (cjs) 116.84 KB (0%) 2.4 s (0%) 5.3 s (-37.98% 🔽) 7.7 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 358 ms (-37.54% 🔽) 469 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 51 ms (-1.86% 🔽) 61 ms
thirdweb/react (minimal + tree-shaking) 19.24 KB (0%) 385 ms (0%) 933 ms (+85.95% 🔺) 1.4 s

@codecov
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.81%. Comparing base (b511a69) to head (39f8db0).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5969      +/-   ##
==========================================
- Coverage   54.82%   54.81%   -0.01%     
==========================================
  Files        1150     1150              
  Lines       61194    61195       +1     
  Branches     5154     5153       -1     
==========================================
- Hits        33548    33545       -3     
- Misses      26919    26923       +4     
  Partials      727      727              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from b511a69
packages 52.46% <ø> (-0.01%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...web/src/utils/extensions/drops/get-claim-params.ts 91.73% <ø> (ø)
...ges/thirdweb/src/wallets/connection/autoConnect.ts 70.83% <ø> (ø)

... and 2 files with indirect coverage changes

@joaquim-verges joaquim-verges marked this pull request as ready for review January 16, 2025 20:33
@joaquim-verges joaquim-verges requested review from a team as code owners January 16, 2025 20:33
@joaquim-verges joaquim-verges merged commit 9f55100 into main Jan 16, 2025
33 of 36 checks passed
@joaquim-verges joaquim-verges deleted the docs_Reorder_sidebar_groups_and_update_claim_params_tags branch January 16, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages Portal Involves changes to the Portal (docs) codebase. SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants