Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Jan 16, 2025

Fixes: TOOL-3114

Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

How to test

Unit tests, playground, etc.

@vercel
Copy link

vercel bot commented Jan 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 10:37pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 10:37pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 10:37pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 10:37pm

@changeset-bot
Copy link

changeset-bot bot commented Jan 16, 2025

⚠️ No Changeset found

Latest commit: 4755e86

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Jan 16, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges changed the title feat: Add pay event tracking for transaction modal states [SDK] feat: Add pay event tracking for transaction modal states Jan 16, 2025
@linear
Copy link

linear bot commented Jan 16, 2025

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.66 KB (0%) 934 ms (0%) 838 ms (+34.41% 🔺) 1.8 s
thirdweb (cjs) 116.84 KB (0%) 2.4 s (0%) 1.5 s (-0.41% 🔽) 3.8 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 228 ms (+110.1% 🔺) 340 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 52 ms (+93.08% 🔺) 62 ms
thirdweb/react (minimal + tree-shaking) 19.24 KB (0%) 385 ms (0%) 213 ms (-1.59% 🔽) 597 ms

@codecov
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 2.94118% with 33 lines in your changes missing coverage. Please review.

Project coverage is 54.79%. Comparing base (fe3f24e) to head (4755e86).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...react/core/hooks/transaction/useSendTransaction.ts 0.00% 33 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5971      +/-   ##
==========================================
- Coverage   54.81%   54.79%   -0.03%     
==========================================
  Files        1150     1150              
  Lines       61195    61233      +38     
  Branches     5153     5150       -3     
==========================================
+ Hits        33545    33551       +6     
- Misses      26923    26955      +32     
  Partials      727      727              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from fe3f24e
packages 52.43% <2.94%> (-0.03%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
packages/thirdweb/src/analytics/track/pay.ts 100.00% <100.00%> (ø)
...react/core/hooks/transaction/useSendTransaction.ts 5.63% <0.00%> (-1.64%) ⬇️

... and 3 files with indirect coverage changes

@joaquim-verges joaquim-verges merged commit eed734c into main Jan 17, 2025
35 of 38 checks passed
@joaquim-verges joaquim-verges deleted the feat_Add_pay_event_tracking_for_transaction_modal_states branch January 17, 2025 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants