Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Jan 17, 2025

PR-Codex overview

This PR primarily focuses on enhancing the visual consistency of various chart components by standardizing the strokeWidth and className properties. Additionally, it introduces pagination improvements and updates the transaction details display.

Detailed summary

  • Standardized strokeWidth to 1 and changed className to "stroke-background" in multiple chart components.
  • Improved pagination functionality in PaginationButtons, allowing for direct page input.
  • Enhanced transaction display with clearer labels and tooltips.
  • Updated UI elements for better visual consistency across components.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Jan 17, 2025

@vercel
Copy link

vercel bot commented Jan 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 7:12pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jan 17, 2025 7:12pm
thirdweb_playground ⬜️ Skipped (Inspect) Jan 17, 2025 7:12pm
wallet-ui ⬜️ Skipped (Inspect) Jan 17, 2025 7:12pm

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 17, 2025 17:30 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 17, 2025 17:30 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 17, 2025 17:30 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Jan 17, 2025

⚠️ No Changeset found

Latest commit: f1afa3b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jan 17, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank marked this pull request as ready for review January 17, 2025 17:31
@MananTank MananTank requested review from a team as code owners January 17, 2025 17:31
@codecov
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.80%. Comparing base (dbb64ea) to head (f1afa3b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5976   +/-   ##
=======================================
  Coverage   54.80%   54.80%           
=======================================
  Files        1150     1150           
  Lines       61237    61237           
  Branches     5154     5154           
=======================================
  Hits        33559    33559           
  Misses      26950    26950           
  Partials      728      728           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from dbb64ea
packages 52.45% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 17, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.66 KB (0%) 934 ms (0%) 611 ms (+73.25% 🔺) 1.6 s
thirdweb (cjs) 116.84 KB (0%) 2.4 s (0%) 786 ms (-7.94% 🔽) 3.2 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 81 ms (+52.24% 🔺) 193 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 81 ms (+401.17% 🔺) 91 ms
thirdweb/react (minimal + tree-shaking) 19.24 KB (0%) 385 ms (0%) 170 ms (+92.42% 🔺) 555 ms

@MananTank MananTank force-pushed the 01-17-_tool-3112_various_engine_overview_page_improvements_chart_style_adjustments_improved_pagination_component branch from 97376e7 to 884d40a Compare January 17, 2025 18:00
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 17, 2025 18:00 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 17, 2025 18:00 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 17, 2025 18:00 Inactive
@MananTank MananTank force-pushed the 01-17-_tool-3112_various_engine_overview_page_improvements_chart_style_adjustments_improved_pagination_component branch from 884d40a to faa53c7 Compare January 17, 2025 18:40
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 17, 2025 18:40 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 17, 2025 18:40 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 17, 2025 18:40 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 17, 2025

Merge activity

…djustments, Improved Pagination component (#5976)

<!-- start pr-codex -->

## PR-Codex overview
This PR primarily focuses on improving the styling and functionality of various chart components, enhancing pagination controls, and refining transaction details presentation in the dashboard application.

### Detailed summary
- Added `strokeWidth` and `className` properties to several chart components for consistent styling.
- Updated pagination components to include input for direct page navigation.
- Enhanced transaction details with improved layout and added tooltips.
- Refined UI elements for better visibility and usability across various components.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 01-17-_tool-3112_various_engine_overview_page_improvements_chart_style_adjustments_improved_pagination_component branch from faa53c7 to f1afa3b Compare January 17, 2025 19:10
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 17, 2025 19:10 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 17, 2025 19:10 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 17, 2025 19:10 Inactive
@graphite-app graphite-app bot merged commit f1afa3b into main Jan 17, 2025
32 checks passed
@graphite-app graphite-app bot deleted the 01-17-_tool-3112_various_engine_overview_page_improvements_chart_style_adjustments_improved_pagination_component branch January 17, 2025 19:21
@vercel vercel bot temporarily deployed to Production – thirdweb_playground January 17, 2025 19:21 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui January 17, 2025 19:22 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 January 17, 2025 19:22 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants