Skip to content

Conversation

@GiselleNessi
Copy link
Contributor

@GiselleNessi GiselleNessi commented Jan 20, 2025


title: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

How to test

Unit tests, playground, etc.


PR-Codex overview

This PR updates the content of the page.mdx file related to the Tabs component, changing the default selected tab and modifying the tab triggers.

Detailed summary

  • Changed the default value of the Tabs component from no default to typescript.
  • The TabsTrigger for the typescript tab remains unchanged.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@GiselleNessi GiselleNessi self-assigned this Jan 20, 2025
@GiselleNessi GiselleNessi requested review from a team as code owners January 20, 2025 18:25
@changeset-bot
Copy link

changeset-bot bot commented Jan 20, 2025

⚠️ No Changeset found

Latest commit: f22f0d5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2025 9:40pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
thirdweb_playground ⬜️ Skipped (Inspect) Jan 20, 2025 9:40pm
thirdweb-www ⬜️ Skipped (Inspect) Jan 20, 2025 9:40pm
wallet-ui ⬜️ Skipped (Inspect) Jan 20, 2025 9:40pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 20, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Jan 20, 2025
@codecov
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.77%. Comparing base (eded4ff) to head (eb49c41).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5991   +/-   ##
=======================================
  Coverage   54.77%   54.77%           
=======================================
  Files        1151     1151           
  Lines       61257    61257           
  Branches     5151     5151           
=======================================
  Hits        33556    33556           
  Misses      26975    26975           
  Partials      726      726           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from eded4ff
packages 52.42% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.66 KB (0%) 934 ms (0%) 266 ms (+23.46% 🔺) 1.2 s
thirdweb (cjs) 116.84 KB (0%) 2.4 s (0%) 515 ms (-11.23% 🔽) 2.9 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 78 ms (+277.41% 🔺) 190 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 22 ms (+320.59% 🔺) 32 ms
thirdweb/react (minimal + tree-shaking) 19.24 KB (0%) 385 ms (0%) 149 ms (+142.4% 🔺) 534 ms

@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Jan 20, 2025
Copy link
Contributor

gregfromstl commented Jan 20, 2025

Merge activity

  • Jan 20, 4:22 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 20, 4:22 PM EST: A user added this pull request to the Graphite merge queue.
  • Jan 20, 4:28 PM EST: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Unit Tests').
  • Jan 20, 4:29 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 20, 9:29 PM UTC: The merge label 'merge-queue' was removed. This PR will no longer be merged by the Graphite merge queue
  • Jan 20, 4:30 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

---
title: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"
---

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer
Anything important to call out? Be sure to also clarify these in your comments.

## How to test
Unit tests, playground, etc.

<!-- start pr-codex -->

---

## PR-Codex overview
This PR updates the content in the `page.mdx` file related to the `Tabs` component, changing the default tab and modifying the displayed information regarding supported currencies.

### Detailed summary
- Changed the default value of the `Tabs` component from none to `"typescript"`.
- Updated the introductory text to specify that users may currently use `Lisk LSK`, `Base USDC`, or `Celo CUSD`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@gregfromstl gregfromstl force-pushed the gi/docs-default-option-tab branch from eb49c41 to f22f0d5 Compare January 20, 2025 21:23
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 20, 2025 21:23 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 20, 2025 21:23 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www January 20, 2025 21:23 Inactive
@graphite-app graphite-app bot removed the merge-queue Adds the pull request to Graphite's merge queue. label Jan 20, 2025
@GiselleNessi GiselleNessi added the merge-queue Adds the pull request to Graphite's merge queue. label Jan 20, 2025
@joaquim-verges joaquim-verges merged commit 3b98fbf into main Jan 20, 2025
28 of 29 checks passed
@joaquim-verges joaquim-verges deleted the gi/docs-default-option-tab branch January 20, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-queue Adds the pull request to Graphite's merge queue. Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants