-
Notifications
You must be signed in to change notification settings - Fork 619
[TOOL-3123] Dashboard: Order projects by total wallets #6026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6026 +/- ##
=======================================
Coverage 54.89% 54.89%
=======================================
Files 1151 1151
Lines 61210 61210
Branches 5167 5167
=======================================
Hits 33600 33600
Misses 26882 26882
Partials 728 728
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
| ); | ||
| } | ||
|
|
||
| async function getProjectsWithTotalWallets( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't this going to slow down the page load quite significantly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was my concern as well - but it seems to be pretty quick ( tested with ~15 projects )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about with projects that have 100k+ wallets in them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The total wallets query is aggregated by walletType - returned response array only includes one object per unique wallet type - so the response size won't be huge
Let me check with @gregfromstl If it that scenario involves significantly more processing time in analytics server ( afaik - its already preprocessed )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's preprocessed up to the day. So you'll be aggregating as many rows as there are days in the time period.
| {truncate(project.publishableKey, 32)} | ||
| <p className="flex items-center gap-1 text-muted-foreground text-sm"> | ||
| <span>{project.totalConnections}</span> | ||
| Total wallet connections |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Total Users
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
Merge activity
|
<!-- start pr-codex -->
## PR-Codex overview
This PR focuses on enhancing the `CopyTextButton` component, optimizing the project fetching logic, and improving project display features by integrating total wallet connections in the dashboard.
### Detailed summary
- Changed `tooltip` type in `CopyTextButton` to `string | undefined`.
- Updated the API call in `getChangelog` to limit results to 7.
- Replaced cookie-based token retrieval with `getAuthToken` in `getProjects`.
- Added `getProjectsWithTotalWallets` to calculate total wallet connections.
- Updated `TeamProjectsPage` to display projects with total connections.
- Modified sorting logic in `TeamProjectsPage` to include total connections.
- Replaced `CopyButton` with `CopyTextButton` in `ProjectCard`.
- Enhanced project display to show total users.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->

PR-Codex overview
This PR focuses on improving the functionality and user experience of the
TeamProjectsPagecomponent by adding total connections to projects, updating theCopyTextButton, and refining project sorting and filtering.Detailed summary
tooltiptype inCopyTextButtontostring | undefined.getChangelog.getAuthTokeningetProjects.getProjectsWithTotalWalletsto calculate total connections for projects.TeamProjectsPageto useProjectWithTotalConnectionstype.totalConnections.CopyButtonwithCopyTextButtoninProjectCard.