Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Jan 22, 2025

PR-Codex overview

This PR introduces functionality to track and save the last visited team page in cookies. It adds constants, components, and cookie management functions, while also integrating this feature into the middleware for proper redirection.

Detailed summary

  • Added LAST_VISITED_TEAM_PAGE_PATH constant in consts.ts.
  • Created SaveLastVisitedTeamPage component to set the last visited page in cookies.
  • Integrated SaveLastVisitedTeamPage in layout.tsx.
  • Implemented getCookie and setCookie functions in cookie.ts.
  • Removed duplicate getCookie and setCookie functions from SyncStoreToCookies.tsx.
  • Updated middleware to redirect to the last visited team page if available.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Jan 22, 2025

@vercel
Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 11:47pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jan 22, 2025 11:47pm
thirdweb_playground ⬜️ Skipped (Inspect) Jan 22, 2025 11:47pm
wallet-ui ⬜️ Skipped (Inspect) Jan 22, 2025 11:47pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 January 22, 2025 19:03 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 22, 2025 19:03 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 22, 2025 19:03 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Jan 22, 2025

⚠️ No Changeset found

Latest commit: 0a19142

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jan 22, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.89%. Comparing base (feb4fd0) to head (0a19142).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6028   +/-   ##
=======================================
  Coverage   54.89%   54.89%           
=======================================
  Files        1151     1151           
  Lines       61210    61210           
  Branches     5167     5167           
=======================================
  Hits        33600    33600           
  Misses      26882    26882           
  Partials      728      728           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from feb4fd0
packages 52.56% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 22, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.71 KB (0%) 935 ms (0%) 4.5 s (+20.69% 🔺) 5.4 s
thirdweb (cjs) 116.78 KB (0%) 2.4 s (0%) 7.9 s (+11.62% 🔺) 10.2 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 198 ms (-18.71% 🔽) 310 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 295 ms (+248.76% 🔺) 305 ms
thirdweb/react (minimal + tree-shaking) 19.22 KB (0%) 385 ms (0%) 603 ms (-14.32% 🔽) 987 ms

@MananTank MananTank marked this pull request as ready for review January 22, 2025 19:09
@MananTank MananTank requested review from a team as code owners January 22, 2025 19:09
@MananTank MananTank changed the title [TOOL-3120] Redirect to last visited team page instead of always /team if authenticated [TOOL-3120] Redirect to last visited team page if authenticated Jan 22, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 22, 2025

Merge activity

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 22, 2025 23:39 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 22, 2025 23:39 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 22, 2025 23:39 Inactive
@graphite-app graphite-app bot merged commit 0a19142 into main Jan 22, 2025
32 checks passed
@graphite-app graphite-app bot deleted the TOOL-3120 branch January 22, 2025 23:47
@vercel vercel bot temporarily deployed to Production – wallet-ui January 22, 2025 23:47 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground January 22, 2025 23:47 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 January 22, 2025 23:47 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants