[SDK] Fix: Opt out of 1559 on lumia mainnet #6032

gregfromstl · 2025-01-22T20:48:00Z

PR-Codex overview

This PR adds a new network entry for the Lumia Mainnet in the fee-data.ts file, enhancing the gas fee data for this specific blockchain environment.

Detailed summary

Added Lumia Mainnet entry to the list of networks in fee-data.ts.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

linear · 2025-01-22T20:48:03Z

TOOL-3198 Disabled EIP-1559 on Lumia Mainnet

gregfromstl · 2025-01-22T20:48:05Z

Merge activity

Jan 22, 3:48 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Jan 22, 5:30 PM EST: A user added this pull request to the Graphite merge queue.
Jan 22, 5:47 PM EST: A user merged this pull request with the Graphite merge queue.

changeset-bot · 2025-01-22T20:48:05Z

⚠️ No Changeset found

Latest commit: 1d8695e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2025-01-22T20:48:05Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 22, 2025 10:47pm
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 22, 2025 10:47pm
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 22, 2025 10:47pm
wallet-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 22, 2025 10:47pm

graphite-app · 2025-01-22T20:48:07Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

graphite-app · 2025-01-22T20:48:56Z

apps/playground-web/src/components/pay/embed.tsx

        },
        prefillBuy: {
-          chain: base,
+          chain: defineChain(466),


The defineChain() call appears to be missing critical EIP-1559 configuration. To explicitly opt out of EIP-1559 for chain 466, please update the chain definition to:

defineChain({ id: 466, eip1559: false })

This ensures the transaction will use legacy gas pricing instead of the EIP-1559 fee market.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

github-actions · 2025-01-22T20:52:54Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	46.71 KB (+0.07% 🔺)	935 ms (+0.07% 🔺)	2.6 s (+22.36% 🔺)	3.5 s
thirdweb (cjs)	116.78 KB (-0.09% 🔽)	2.4 s (-0.09% 🔽)	5.4 s (+7.53% 🔺)	7.8 s
thirdweb (minimal + tree-shaking)	5.59 KB (0%)	112 ms (0%)	511 ms (+91.6% 🔺)	622 ms
thirdweb/chains (tree-shaking)	506 B (0%)	10 ms (0%)	124 ms (-8.14% 🔽)	134 ms
thirdweb/react (minimal + tree-shaking)	19.22 KB (0%)	385 ms (0%)	451 ms (-37.38% 🔽)	836 ms

codecov · 2025-01-22T20:56:23Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.89%. Comparing base (858dc53) to head (1d8695e).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6032   +/-   ##
=======================================
  Coverage   54.89%   54.89%           
=======================================
  Files        1151     1151           
  Lines       61209    61210    +1     
  Branches     5159     5167    +8     
=======================================
+ Hits        33598    33600    +2     
+ Misses      26883    26882    -1     
  Partials      728      728

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from 858dc53
packages	`52.56% <100.00%> (+<0.01%)`	⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines	Coverage Δ
packages/thirdweb/src/gas/fee-data.ts	`72.78% <100.00%> (+0.18%)`	⬆️

... and 1 file with indirect coverage changes

## PR-Codex overview This PR adds a new entry for the `Lumia Mainnet` to the fee data list in the `fee-data.ts` file. ### Detailed summary - Added `Lumia Mainnet` entry to the fee data list in `packages/thirdweb/src/gas/fee-data.ts`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

## PR-Codex overview This PR adds support for the `Lumia Mainnet` in the fee data configuration. ### Detailed summary - Added a new entry for `Lumia Mainnet` in the fee data array. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Jan 22, 2025

gregfromstl requested review from a team as code owners January 22, 2025 20:48

github-actions bot assigned gregfromstl Jan 22, 2025

github-actions bot added the Playground Changes involving the Playground codebase. label Jan 22, 2025

graphite-app bot reviewed Jan 22, 2025

View reviewed changes

gregfromstl force-pushed the greg/tool-3198-disabled-eip-1559-on-lumia-mainnet branch from 5cb578d to 85b0441 Compare January 22, 2025 20:49

github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Jan 22, 2025

vercel bot deployed to Preview – wallet-ui January 22, 2025 20:52 View deployment

vercel bot deployed to Preview – thirdweb_playground January 22, 2025 20:52 View deployment

vercel bot deployed to Preview – docs-v2 January 22, 2025 20:57 View deployment

vercel bot deployed to Preview – thirdweb-www January 22, 2025 20:57 View deployment

joaquim-verges approved these changes Jan 22, 2025

View reviewed changes

gregfromstl force-pushed the greg/tool-3198-disabled-eip-1559-on-lumia-mainnet branch from 85b0441 to 02a8dbf Compare January 22, 2025 22:31

vercel bot deployed to Preview – thirdweb_playground January 22, 2025 22:33 View deployment

vercel bot deployed to Preview – docs-v2 January 22, 2025 22:33 View deployment

vercel bot deployed to Preview – wallet-ui January 22, 2025 22:33 View deployment

gregfromstl force-pushed the greg/tool-3198-disabled-eip-1559-on-lumia-mainnet branch from 02a8dbf to 1d8695e Compare January 22, 2025 22:34

vercel bot deployed to Preview – thirdweb_playground January 22, 2025 22:39 View deployment

vercel bot deployed to Preview – wallet-ui January 22, 2025 22:40 View deployment

vercel bot deployed to Preview – docs-v2 January 22, 2025 22:42 View deployment

vercel bot deployed to Preview – thirdweb-www January 22, 2025 22:47 View deployment

graphite-app bot merged commit 1d8695e into main Jan 22, 2025
32 checks passed

graphite-app bot deleted the greg/tool-3198-disabled-eip-1559-on-lumia-mainnet branch January 22, 2025 22:47

vercel bot deployed to Production – wallet-ui January 22, 2025 22:49 View deployment

vercel bot deployed to Production – docs-v2 January 22, 2025 22:50 View deployment

vercel bot deployed to Production – thirdweb_playground January 22, 2025 22:50 View deployment

vercel bot deployed to Production – thirdweb-www January 22, 2025 22:55 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[SDK] Fix: Opt out of 1559 on lumia mainnet #6032

[SDK] Fix: Opt out of 1559 on lumia mainnet #6032

Uh oh!

gregfromstl commented Jan 22, 2025 •

edited by pr-codex bot

Loading

Uh oh!

linear bot commented Jan 22, 2025

Uh oh!

gregfromstl commented Jan 22, 2025 •

edited by graphite-app bot

Loading

Uh oh!

changeset-bot bot commented Jan 22, 2025 •

edited

Loading

Uh oh!

vercel bot commented Jan 22, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Jan 22, 2025

Uh oh!

graphite-app bot Jan 22, 2025

Uh oh!

github-actions bot commented Jan 22, 2025 •

edited

Loading

Uh oh!

codecov bot commented Jan 22, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[SDK] Fix: Opt out of 1559 on lumia mainnet #6032

[SDK] Fix: Opt out of 1559 on lumia mainnet #6032

Uh oh!

Conversation

gregfromstl commented Jan 22, 2025 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR-Codex overview

Detailed summary

Uh oh!

linear bot commented Jan 22, 2025

Uh oh!

gregfromstl commented Jan 22, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

changeset-bot bot commented Jan 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

vercel bot commented Jan 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graphite-app bot commented Jan 22, 2025

How to use the Graphite Merge Queue

Uh oh!

graphite-app bot Jan 22, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

codecov bot commented Jan 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gregfromstl commented Jan 22, 2025 •

edited by pr-codex bot

Loading

gregfromstl commented Jan 22, 2025 •

edited by graphite-app bot

Loading

changeset-bot bot commented Jan 22, 2025 •

edited

Loading

vercel bot commented Jan 22, 2025 •

edited

Loading

github-actions bot commented Jan 22, 2025 •

edited

Loading

codecov bot commented Jan 22, 2025 •

edited

Loading