Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Jan 22, 2025


title: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

How to test

Unit tests, playground, etc.


PR-Codex overview

This PR enhances error logging in the analytics.ts file by including the response body in the error messages when a fetch request fails. This provides more context for debugging.

Detailed summary

  • Added a line to capture the response text in a reason variable when the response status is not 200.
  • Updated the error logging to include the reason in the message for both user ops usage and client transactions stats fetch failures.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Jan 22, 2025

⚠️ No Changeset found

Latest commit: 961aa91

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 10:41pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jan 22, 2025 10:41pm
thirdweb_playground ⬜️ Skipped (Inspect) Jan 22, 2025 10:41pm
wallet-ui ⬜️ Skipped (Inspect) Jan 22, 2025 10:41pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui January 22, 2025 22:33 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 22, 2025 22:33 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 22, 2025 22:34 Inactive
@joaquim-verges joaquim-verges marked this pull request as ready for review January 22, 2025 22:34
@joaquim-verges joaquim-verges requested review from a team as code owners January 22, 2025 22:34
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jan 22, 2025
Copy link
Member Author

joaquim-verges commented Jan 22, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges merged commit 858dc53 into main Jan 22, 2025
20 of 24 checks passed
@joaquim-verges joaquim-verges deleted the _Dashboard_fix_Add_error_reason_to_analytics_API_error_logs branch January 22, 2025 22:34
@codecov
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.89%. Comparing base (8997fac) to head (961aa91).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6034   +/-   ##
=======================================
  Coverage   54.89%   54.89%           
=======================================
  Files        1151     1151           
  Lines       61209    61209           
  Branches     5159     5159           
=======================================
  Hits        33598    33598           
  Misses      26883    26883           
  Partials      728      728           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 8997fac
packages 52.55% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.68 KB (0%) 934 ms (0%) 2.8 s (-27.04% 🔽) 3.8 s
thirdweb (cjs) 116.87 KB (0%) 2.4 s (0%) 7.7 s (+1.5% 🔺) 10 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 1.1 s (+259.8% 🔺) 1.2 s
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 50 ms (-60.32% 🔽) 60 ms
thirdweb/react (minimal + tree-shaking) 19.22 KB (0%) 385 ms (0%) 1.1 s (+16.1% 🔺) 1.5 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants