Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Jan 22, 2025


title: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

How to test

Unit tests, playground, etc.


PR-Codex overview

This PR focuses on enhancing the analytics functionality within the dashboard by refactoring components and optimizing data handling, particularly in relation to transactions and charts.

Detailed summary

  • Renamed revalidate to maxDuration in page.tsx.
  • Introduced uniqueChainIds to filter and handle unique chain IDs in TransactionsCard.tsx.
  • Added TransactionsCharts component with loading state in index.tsx.
  • Implemented TransactionsChartCardAsync for async data fetching.
  • Created ChainDistributionCard and ContractDistributionCard for displaying analytics data in pie charts.
  • Removed redundant code related to chain and contract distribution from page.tsx.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel vercel bot temporarily deployed to Preview – wallet-ui January 22, 2025 22:59 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 22, 2025 22:59 Inactive
@vercel
Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 0:41am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jan 23, 2025 0:41am
thirdweb_playground ⬜️ Skipped (Inspect) Jan 23, 2025 0:41am
wallet-ui ⬜️ Skipped (Inspect) Jan 23, 2025 0:41am

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 22, 2025 22:59 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Jan 22, 2025

⚠️ No Changeset found

Latest commit: 3022173

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joaquim-verges joaquim-verges marked this pull request as ready for review January 22, 2025 22:59
@joaquim-verges joaquim-verges requested review from a team as code owners January 22, 2025 22:59
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jan 22, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.89%. Comparing base (1d8695e) to head (14cdb6d).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6035   +/-   ##
=======================================
  Coverage   54.89%   54.89%           
=======================================
  Files        1151     1151           
  Lines       61210    61210           
  Branches     5167     5167           
=======================================
  Hits        33600    33600           
  Misses      26882    26882           
  Partials      728      728           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 1d8695e
packages 52.56% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 22, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.71 KB (0%) 935 ms (0%) 2.8 s (-3.74% 🔽) 3.7 s
thirdweb (cjs) 116.78 KB (0%) 2.4 s (0%) 8.6 s (-6.36% 🔽) 10.9 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 463 ms (+87.29% 🔺) 575 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 222 ms (+54.03% 🔺) 232 ms
thirdweb/react (minimal + tree-shaking) 19.22 KB (0%) 385 ms (0%) 667 ms (-0.01% 🔽) 1.1 s

@joaquim-verges joaquim-verges force-pushed the _Dashboard_perf_Optimize_chain_and_contract_data_processing branch from c44139f to 3022173 Compare January 23, 2025 00:27
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 23, 2025 00:27 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 23, 2025 00:27 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 23, 2025 00:27 Inactive
@joaquim-verges joaquim-verges force-pushed the _Dashboard_perf_Optimize_chain_and_contract_data_processing branch from 3022173 to 14cdb6d Compare January 23, 2025 00:29
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 23, 2025 00:29 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 23, 2025 00:29 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 23, 2025 00:29 Inactive
@joaquim-verges joaquim-verges merged commit 9f79277 into main Jan 23, 2025
31 of 32 checks passed
@joaquim-verges joaquim-verges deleted the _Dashboard_perf_Optimize_chain_and_contract_data_processing branch January 23, 2025 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants