Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Jan 22, 2025

=


PR-Codex overview

This PR focuses on enhancing the UnixTimeConverter component by improving its functionality and user interface, while also restructuring the layout of the tools section.

Detailed summary

  • Removed the tabs.tsx file.
  • Wrapped UnixTimeConverter in a ClientOnly component in page.tsx.
  • Replaced the previous layout with a SidebarLayout in layout.tsx.
  • Updated UnixTimeConverter to use useMemo for date calculations.
  • Added various date formatting functions and improved error handling.
  • Enhanced the user interface with a card layout and additional date formats.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Jan 22, 2025

@vercel
Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 0:06am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jan 23, 2025 0:06am
thirdweb_playground ⬜️ Skipped (Inspect) Jan 23, 2025 0:06am
wallet-ui ⬜️ Skipped (Inspect) Jan 23, 2025 0:06am

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 22, 2025 23:14 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 22, 2025 23:14 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 22, 2025 23:14 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Jan 22, 2025

⚠️ No Changeset found

Latest commit: 385179e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jan 22, 2025
@MananTank MananTank marked this pull request as ready for review January 22, 2025 23:14
@MananTank MananTank requested review from a team as code owners January 22, 2025 23:14
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.89%. Comparing base (69b1ee9) to head (6e0fd20).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6036   +/-   ##
=======================================
  Coverage   54.89%   54.89%           
=======================================
  Files        1151     1151           
  Lines       61210    61210           
  Branches     5167     5167           
=======================================
  Hits        33600    33600           
  Misses      26882    26882           
  Partials      728      728           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 69b1ee9
packages 52.56% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@MananTank MananTank changed the title [TOOL-2964] Dashboard: Fix crash on unix-converter for invalid unix time, UI improvements [TOOL-2964] Dashboard: Fix crash on unix time converter page for invalid unix time, UI improvements Jan 22, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jan 22, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.71 KB (0%) 935 ms (0%) 2.4 s (-19.75% 🔽) 3.3 s
thirdweb (cjs) 116.78 KB (0%) 2.4 s (0%) 6.1 s (-8.78% 🔽) 8.4 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 240 ms (-41.55% 🔽) 351 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 176 ms (+124.34% 🔺) 186 ms
thirdweb/react (minimal + tree-shaking) 19.22 KB (0%) 385 ms (0%) 640 ms (+56.8% 🔺) 1.1 s

@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 22, 2025

Merge activity

@MananTank MananTank force-pushed the 01-23-_tool-2964_dashboard_fix_crash_on_unix-converter_for_invalid_unix_time_ui_improvements branch from 385179e to 6e0fd20 Compare January 22, 2025 23:58
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 22, 2025 23:58 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 22, 2025 23:58 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 22, 2025 23:58 Inactive
@graphite-app graphite-app bot merged commit 6e0fd20 into main Jan 23, 2025
32 checks passed
@graphite-app graphite-app bot deleted the 01-23-_tool-2964_dashboard_fix_crash_on_unix-converter_for_invalid_unix_time_ui_improvements branch January 23, 2025 00:06
@vercel vercel bot temporarily deployed to Production – wallet-ui January 23, 2025 00:06 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground January 23, 2025 00:06 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 January 23, 2025 00:06 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants