Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Jan 23, 2025

No description provided.

@linear
Copy link

linear bot commented Jan 23, 2025

@vercel
Copy link

vercel bot commented Jan 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 11:57pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 11:57pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 11:57pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 11:57pm

@changeset-bot
Copy link

changeset-bot bot commented Jan 23, 2025

⚠️ No Changeset found

Latest commit: 017abe3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Jan 23, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank marked this pull request as ready for review January 23, 2025 19:50
@MananTank MananTank requested review from a team, jnsdls and joaquim-verges as code owners January 23, 2025 19:50
@MananTank MananTank changed the title [TOOL-3207] Portal:Delete V4 SDK pages, Setup knip lint, Fix lint config [TOOL-3207] Portal: Delete V4 SDK pages, Setup knip lint, Fix lint config Jan 23, 2025
Copy link
Member

@0xFirekeeper 0xFirekeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wish I could click approve twice

@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.71 KB (0%) 935 ms (0%) 630 ms (+55.3% 🔺) 1.6 s
thirdweb (cjs) 116.78 KB (0%) 2.4 s (0%) 797 ms (-19.47% 🔽) 3.2 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 75 ms (+10.26% 🔺) 187 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 43 ms (+129.17% 🔺) 53 ms
thirdweb/react (minimal + tree-shaking) 19.22 KB (0%) 385 ms (0%) 176 ms (+66.53% 🔺) 560 ms

@codecov
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.89%. Comparing base (ace1dc5) to head (017abe3).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6039   +/-   ##
=======================================
  Coverage   54.89%   54.89%           
=======================================
  Files        1151     1151           
  Lines       61210    61210           
  Branches     5167     5159    -8     
=======================================
+ Hits        33600    33603    +3     
+ Misses      26882    26878    -4     
- Partials      728      729    +1     
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from ace1dc5
packages 52.56% <ø> (+<0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

see 3 files with indirect coverage changes

@joaquim-verges joaquim-verges merged commit b81d7a1 into main Jan 24, 2025
31 checks passed
@joaquim-verges joaquim-verges deleted the TOOL-3207 branch January 24, 2025 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants