Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Jan 23, 2025

PR-Codex overview

This PR focuses on enhancing the SearchInput and SelectBy components by modifying their onValueChange and onChange handlers to reset the page to 1 whenever the input value changes.

Detailed summary

  • Updated SearchInput to reset the page to 1 on value change.
  • Updated SelectBy to reset the page to 1 on value change.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Jan 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 0:01am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 0:01am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 0:01am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 0:01am

@linear
Copy link

linear bot commented Jan 23, 2025

@changeset-bot
Copy link

changeset-bot bot commented Jan 23, 2025

⚠️ No Changeset found

Latest commit: b2cc17f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added Dashboard Involves changes to the Dashboard. packages SDK Involves changes to the thirdweb SDK labels Jan 23, 2025
@MananTank MananTank marked this pull request as ready for review January 23, 2025 21:40
@MananTank MananTank requested review from a team as code owners January 23, 2025 21:40
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.71 KB (0%) 935 ms (0%) 360 ms (+4.05% 🔺) 1.3 s
thirdweb (cjs) 116.78 KB (0%) 2.4 s (0%) 871 ms (-12.41% 🔽) 3.3 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 82 ms (+152.69% 🔺) 194 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 31 ms (+130.58% 🔺) 41 ms
thirdweb/react (minimal + tree-shaking) 19.22 KB (0%) 385 ms (0%) 179 ms (+271.09% 🔺) 563 ms

@codecov
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.90%. Comparing base (ace1dc5) to head (b2cc17f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6041   +/-   ##
=======================================
  Coverage   54.89%   54.90%           
=======================================
  Files        1151     1151           
  Lines       61210    61210           
  Branches     5167     5159    -8     
=======================================
+ Hits        33600    33605    +5     
+ Misses      26882    26877    -5     
  Partials      728      728           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from ace1dc5
packages 52.56% <ø> (+<0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...dweb/src/react/web/ui/prebuilt/Wallet/provider.tsx 100.00% <ø> (ø)

... and 4 files with indirect coverage changes

@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 23, 2025

Merge activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants