Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Jan 23, 2025

Fixes TOOL-2726

@vercel
Copy link

vercel bot commented Jan 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 11:59pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jan 23, 2025 11:59pm
thirdweb_playground ⬜️ Skipped (Inspect) Jan 23, 2025 11:59pm
wallet-ui ⬜️ Skipped (Inspect) Jan 23, 2025 11:59pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui January 23, 2025 23:52 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 23, 2025 23:52 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 23, 2025 23:52 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Jan 23, 2025

⚠️ No Changeset found

Latest commit: 7137e43

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jan 23, 2025
@linear
Copy link

linear bot commented Jan 23, 2025

@joaquim-verges joaquim-verges marked this pull request as ready for review January 23, 2025 23:52
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges requested review from a team as code owners January 23, 2025 23:52
@codecov
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.89%. Comparing base (ace1dc5) to head (7137e43).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6044   +/-   ##
=======================================
  Coverage   54.89%   54.89%           
=======================================
  Files        1151     1151           
  Lines       61210    61210           
  Branches     5167     5167           
=======================================
  Hits        33600    33600           
  Misses      26882    26882           
  Partials      728      728           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from ace1dc5
packages 52.56% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.71 KB (0%) 935 ms (0%) 566 ms (+2.24% 🔺) 1.5 s
thirdweb (cjs) 116.78 KB (0%) 2.4 s (0%) 887 ms (-20.01% 🔽) 3.3 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 110 ms (+166.5% 🔺) 221 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 12 ms (+8.93% 🔺) 22 ms
thirdweb/react (minimal + tree-shaking) 19.22 KB (0%) 385 ms (0%) 147 ms (+46.86% 🔺) 531 ms

@joaquim-verges joaquim-verges merged commit 4b30b84 into main Jan 24, 2025
36 of 37 checks passed
@joaquim-verges joaquim-verges deleted the _Dashboard_fix_Use_formatted_ABI_for_contract_function_calls branch January 24, 2025 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants