Skip to content

Conversation

@arcoraven
Copy link
Contributor

@arcoraven arcoraven commented Jan 24, 2025

Fixes: CORE-713

PR-Codex overview

This PR primarily focuses on updating the usageV2 structure by renaming a property and ensuring its export across various modules.

Detailed summary

  • In packages/service-utils/src/core/usageV2.ts:

    • Renamed property client_id to project_id.
  • In packages/service-utils/src/cf-worker/index.ts:

    • Added export for ../core/usageV2.js.
  • In packages/service-utils/src/node/index.ts:

    • Added export for ../core/usageV2.js.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@arcoraven arcoraven requested a review from a team as a code owner January 24, 2025 08:43
@changeset-bot
Copy link

changeset-bot bot commented Jan 24, 2025

⚠️ No Changeset found

Latest commit: 43fd3d7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 8:44am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 8:44am
thirdweb-www ❌ Failed (Inspect) Jan 24, 2025 8:44am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 8:44am

@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 24, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@linear
Copy link

linear bot commented Jan 24, 2025

@arcoraven arcoraven merged commit bc34537 into main Jan 24, 2025
13 of 30 checks passed
@arcoraven arcoraven deleted the ph/usageV2ProjectId branch January 24, 2025 08:44
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.69 KB (0%) 934 ms (0%) 3.9 s (+56.37% 🔺) 4.8 s
thirdweb (cjs) 116.89 KB (0%) 2.4 s (0%) 8.7 s (+13.44% 🔺) 11 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 369 ms (-3.47% 🔽) 481 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 101 ms (-17.49% 🔽) 111 ms
thirdweb/react (minimal + tree-shaking) 19.22 KB (0%) 385 ms (0%) 778 ms (+68.75% 🔺) 1.2 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants