Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Jan 27, 2025

closes: CORE-714

TL;DR

Removed the Growth plan trial functionality and updated pricing card highlighting

What changed?

  • Changed growthTrialEligible type from boolean | null to false
  • Removed trial-related UI elements and messaging from the pricing component
  • Added highlighting for starter plan users in the Growth pricing card
  • Simplified CTA button labels to "Get started" and "Upgrade"
  • Updated tracking labels to remove trial-specific events

How to test?

  1. Visit the billing/pricing page as a free plan user
  2. Verify the Growth plan card shows "Get started" without trial messaging
  3. Visit as a starter plan user
  4. Confirm the Growth plan card shows "Upgrade" without trial messaging
  5. Verify both free and starter plan users see the Growth card highlighted

Why make this change?

To discontinue the Growth plan trial offering and simplify the upgrade path for users on free and starter plans


PR-Codex overview

This PR focuses on updating the growthTrialEligible feature across various files, changing its value to false and adjusting related logic in the billing settings component.

Detailed summary

  • Set growthTrialEligible to false in apps/dashboard/src/stories/stubs.ts, apps/dashboard/src/@/api/team.ts, and packages/service-utils/src/core/api.ts.
  • Removed conditional labels based on growthTrialEligible in apps/dashboard/src/components/settings/Account/Billing/Pricing.tsx.
  • Adjusted canTrialGrowth to always be false.
  • Updated highlighted logic to include starter plan in Pricing.tsx.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Jan 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 11:10pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jan 27, 2025 11:10pm
thirdweb_playground ⬜️ Skipped (Inspect) Jan 27, 2025 11:10pm
wallet-ui ⬜️ Skipped (Inspect) Jan 27, 2025 11:10pm

@changeset-bot
Copy link

changeset-bot bot commented Jan 27, 2025

⚠️ No Changeset found

Latest commit: 428777c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – docs-v2 January 27, 2025 21:45 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 27, 2025 21:45 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 27, 2025 21:45 Inactive
@jnsdls jnsdls marked this pull request as ready for review January 27, 2025 21:45
@jnsdls jnsdls requested a review from a team as a code owner January 27, 2025 21:46
@github-actions github-actions bot added Dashboard Involves changes to the Dashboard. packages labels Jan 27, 2025
@jnsdls jnsdls requested a review from a team as a code owner January 27, 2025 21:46
Copy link
Member Author

jnsdls commented Jan 27, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.01%. Comparing base (86f205e) to head (5c2f214).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6070   +/-   ##
=======================================
  Coverage   55.01%   55.01%           
=======================================
  Files        1152     1152           
  Lines       61280    61280           
  Branches     5186     5186           
=======================================
  Hits        33716    33716           
  Misses      26834    26834           
  Partials      730      730           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 86f205e
packages 52.71% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.85 KB (0%) 938 ms (0%) 483 ms (+0.96% 🔺) 1.5 s
thirdweb (cjs) 123.65 KB (0%) 2.5 s (0%) 839 ms (-14.67% 🔽) 3.4 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 100 ms (+114.25% 🔺) 212 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 26 ms (+300% 🔺) 36 ms
thirdweb/react (minimal + tree-shaking) 19.08 KB (0%) 382 ms (0%) 95 ms (+3.13% 🔺) 477 ms

@linear
Copy link

linear bot commented Jan 27, 2025

@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 27, 2025

Merge activity

  • Jan 27, 6:02 PM EST: A user added this pull request to the Graphite merge queue.
  • Jan 27, 6:08 PM EST: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Unit Tests').

closes: CORE-714

### TL;DR
Removed the Growth plan trial functionality and updated pricing card highlighting

### What changed?
- Changed `growthTrialEligible` type from `boolean | null` to `false`
- Removed trial-related UI elements and messaging from the pricing component
- Added highlighting for starter plan users in the Growth pricing card
- Simplified CTA button labels to "Get started" and "Upgrade"
- Updated tracking labels to remove trial-specific events

### How to test?
1. Visit the billing/pricing page as a free plan user
2. Verify the Growth plan card shows "Get started" without trial messaging
3. Visit as a starter plan user
4. Confirm the Growth plan card shows "Upgrade" without trial messaging
5. Verify both free and starter plan users see the Growth card highlighted

### Why make this change?
To discontinue the Growth plan trial offering and simplify the upgrade path for users on free and starter plans
@jnsdls jnsdls force-pushed the remove_growth_trial_eligibility branch from 5c2f214 to 428777c Compare January 27, 2025 23:03
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 27, 2025 23:04 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 27, 2025 23:04 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 27, 2025 23:04 Inactive
@jnsdls jnsdls merged commit 47dce2e into main Jan 27, 2025
28 of 29 checks passed
@jnsdls jnsdls deleted the remove_growth_trial_eligibility branch January 27, 2025 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants