Skip to content

Conversation

@saminacodes
Copy link
Member

@saminacodes saminacodes commented Jan 28, 2025


PR-Codex overview

This PR focuses on enhancing security practices by updating the documentation regarding secret key management and modifying the implementation for generating accounts in the handleNebulaResponse function.

Detailed summary

  • Updated the warning in the Callout to remove mention of the private key.
  • Changed the account generation method from privateKeyToAccount to generateAccount using thirdweb/wallets.
  • Added a comment indicating that any wallet can be used.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@saminacodes saminacodes requested review from a team as code owners January 28, 2025 02:18
@changeset-bot
Copy link

changeset-bot bot commented Jan 28, 2025

⚠️ No Changeset found

Latest commit: b830de0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 2:38am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
thirdweb_playground ⬜️ Skipped (Inspect) Jan 28, 2025 2:38am
thirdweb-www ⬜️ Skipped (Inspect) Jan 28, 2025 2:38am
wallet-ui ⬜️ Skipped (Inspect) Jan 28, 2025 2:38am

@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 28, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Jan 28, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.85 KB (0%) 938 ms (0%) 543 ms (+82.43% 🔺) 1.5 s
thirdweb (cjs) 123.65 KB (0%) 2.5 s (0%) 714 ms (-14.5% 🔽) 3.2 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 55 ms (-41.52% 🔽) 167 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 25 ms (+243.15% 🔺) 35 ms
thirdweb/react (minimal + tree-shaking) 19.08 KB (0%) 382 ms (0%) 155 ms (+95.4% 🔺) 537 ms

@vercel vercel bot temporarily deployed to Preview – wallet-ui January 28, 2025 02:31 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 28, 2025 02:31 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www January 28, 2025 02:31 Inactive
@jakeloo jakeloo merged commit aa548a3 into main Jan 28, 2025
26 of 28 checks passed
@jakeloo jakeloo deleted the nebula-docs branch January 28, 2025 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants