Skip to content

Conversation

@vernonjohnson
Copy link

@vernonjohnson vernonjohnson commented Jan 29, 2025


PR-Codex overview

This PR focuses on enhancing the transaction activity fetching and display functionality in the dashboard. It includes error handling, data type adjustments, and UI improvements for better user experience.

Detailed summary

  • Added error handling in fetchTxActivity to log errors and return an empty array.
  • Changed value type from bigint to string in TransactionDetails and updated related logic.
  • Filtered fungibleTokens to exclude null names or symbols.
  • Updated ActivityOverview to display transaction details with improved layout and formatting.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vernonjohnson vernonjohnson requested review from a team as code owners January 29, 2025 18:11
@changeset-bot
Copy link

changeset-bot bot commented Jan 29, 2025

⚠️ No Changeset found

Latest commit: 6cec6ff

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 6:25pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jan 29, 2025 6:25pm
thirdweb_playground ⬜️ Skipped (Inspect) Jan 29, 2025 6:25pm
wallet-ui ⬜️ Skipped (Inspect) Jan 29, 2025 6:25pm

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jan 29, 2025
@codecov
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (hackweek-wallet-explainer@ed66c51). Learn more about missing BASE report.

Additional details and impacted files
@@                     Coverage Diff                      @@
##             hackweek-wallet-explainer    #6091   +/-   ##
============================================================
  Coverage                             ?   56.82%           
============================================================
  Files                                ?     1152           
  Lines                                ?    63904           
  Branches                             ?     5180           
============================================================
  Hits                                 ?    36314           
  Misses                               ?    26861           
  Partials                             ?      729           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (?) Carriedforward from 95236ed
packages 55.00% <ø> (?)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 29, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.55 KB (0%) 932 ms (0%) 238 ms (+128.68% 🔺) 1.2 s
thirdweb (cjs) 122.35 KB (0%) 2.5 s (0%) 302 ms (+45.11% 🔺) 2.8 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 95 ms (+1824.12% 🔺) 206 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 13 ms (+105.51% 🔺) 23 ms
thirdweb/react (minimal + tree-shaking) 19.27 KB (0%) 386 ms (0%) 98 ms (+373.6% 🔺) 483 ms

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 29, 2025 18:16 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 29, 2025 18:16 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 29, 2025 18:16 Inactive
@vernonjohnson vernonjohnson merged commit 67dd7e3 into hackweek-wallet-explainer Jan 29, 2025
27 of 29 checks passed
@vernonjohnson vernonjohnson deleted the vt-hackweek-wallet-analysis-cleanup branch January 29, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants