Skip to content

Conversation

@arcoraven
Copy link
Contributor

@arcoraven arcoraven commented Jan 31, 2025

PR-Codex overview

This PR updates the UsageV2Producer class to use the new import style for kafkajs, transitioning from a namespace import to a named import. It also refines type usage for Kafka-related types and compression settings.

Detailed summary

  • Changed import of kafkajs from namespace to named imports.
  • Updated type declarations for kafka, producer, and compression.
  • Adjusted default value for compression to use the new import style.
  • Refined the init method to utilize the new ProducerConfig type.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@arcoraven arcoraven requested a review from a team as a code owner January 31, 2025 01:23
@changeset-bot
Copy link

changeset-bot bot commented Jan 31, 2025

⚠️ No Changeset found

Latest commit: 255c496

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 1:33am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jan 31, 2025 1:33am
login ⬜️ Skipped (Inspect) Jan 31, 2025 1:33am
thirdweb_playground ⬜️ Skipped (Inspect) Jan 31, 2025 1:33am
wallet-ui ⬜️ Skipped (Inspect) Jan 31, 2025 1:33am

@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 31, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@codecov
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.87%. Comparing base (5de72c5) to head (255c496).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6127   +/-   ##
=======================================
  Coverage   56.87%   56.87%           
=======================================
  Files        1153     1153           
  Lines       63896    63896           
  Branches     5180     5180           
=======================================
  Hits        36344    36344           
  Misses      26825    26825           
  Partials      727      727           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 77a153f
packages 55.07% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@vercel vercel bot temporarily deployed to Preview – login January 31, 2025 01:25 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 31, 2025 01:25 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 31, 2025 01:25 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 31, 2025 01:25 Inactive
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.6 KB (0%) 933 ms (0%) 3.6 s (-8.21% 🔽) 4.5 s
thirdweb (cjs) 122.39 KB (0%) 2.5 s (0%) 7.6 s (-3.47% 🔽) 10 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 405 ms (+46.25% 🔺) 517 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 66 ms (-12.7% 🔽) 76 ms
thirdweb/react (minimal + tree-shaking) 19.28 KB (0%) 386 ms (0%) 945 ms (+55.95% 🔺) 1.4 s

@arcoraven arcoraven merged commit ca75681 into main Jan 31, 2025
29 of 31 checks passed
@arcoraven arcoraven deleted the ph/usageV2Imports branch January 31, 2025 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants