Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Jan 31, 2025

PR-Codex overview

This PR updates the import path for the createThirdwebClient function in the download.ts file, changing it from @thirdweb-dev/sdk to thirdweb.

Detailed summary

  • Changed import of createThirdwebClient from @thirdweb-dev/sdk to thirdweb in packages/thirdweb/src/storage/download.ts.
  • This change is reflected in multiple locations within the file.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Jan 31, 2025

@changeset-bot
Copy link

changeset-bot bot commented Jan 31, 2025

⚠️ No Changeset found

Latest commit: f03ded3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2025 3:30am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2025 3:30am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2025 3:30am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2025 3:30am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2025 3:30am

@MananTank MananTank marked this pull request as ready for review January 31, 2025 19:20
@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Jan 31, 2025
@MananTank MananTank requested review from a team as code owners January 31, 2025 19:20
Copy link
Member Author

MananTank commented Jan 31, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.6 KB (0%) 933 ms (0%) 806 ms (+82.62% 🔺) 1.8 s
thirdweb (cjs) 122.39 KB (0%) 2.5 s (0%) 1.3 s (-14.46% 🔽) 3.7 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 136 ms (+112.92% 🔺) 248 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 12 ms (+6.17% 🔺) 22 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 197 ms (+69.35% 🔺) 583 ms

@codecov
Copy link

codecov bot commented Feb 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.90%. Comparing base (b651bae) to head (f03ded3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6133      +/-   ##
==========================================
- Coverage   56.92%   56.90%   -0.03%     
==========================================
  Files        1155     1155              
  Lines       63916    63916              
  Branches     5192     5193       +1     
==========================================
- Hits        36384    36369      -15     
- Misses      26803    26821      +18     
+ Partials      729      726       -3     
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from b651bae
packages 55.09% <ø> (-0.03%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
packages/thirdweb/src/storage/download.ts 100.00% <ø> (ø)

... and 4 files with indirect coverage changes

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 2, 2025

Merge activity

<!-- start pr-codex -->

## PR-Codex overview
This PR focuses on updating the import path for the `createThirdwebClient` function from `@thirdweb-dev/sdk` to `thirdweb` in the `download.ts` file.

### Detailed summary
- Changed import of `createThirdwebClient` from `@thirdweb-dev/sdk` to `thirdweb` in multiple instances within the `download.ts` file.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants