-
Notifications
You must be signed in to change notification settings - Fork 619
[TOOL-3276] SDK: Fix JSDoc comments of download function #6133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
dc5f793 to
ca75681
Compare
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6133 +/- ##
==========================================
- Coverage 56.92% 56.90% -0.03%
==========================================
Files 1155 1155
Lines 63916 63916
Branches 5192 5193 +1
==========================================
- Hits 36384 36369 -15
- Misses 26803 26821 +18
+ Partials 729 726 -3
*This pull request uses carry forward flags. Click here to find out more.
|
Merge activity
|
<!-- start pr-codex -->
## PR-Codex overview
This PR focuses on updating the import path for the `createThirdwebClient` function from `@thirdweb-dev/sdk` to `thirdweb` in the `download.ts` file.
### Detailed summary
- Changed import of `createThirdwebClient` from `@thirdweb-dev/sdk` to `thirdweb` in multiple instances within the `download.ts` file.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
6e5b7ec to
f03ded3
Compare

PR-Codex overview
This PR updates the import path for the
createThirdwebClientfunction in thedownload.tsfile, changing it from@thirdweb-dev/sdktothirdweb.Detailed summary
createThirdwebClientfrom@thirdweb-dev/sdktothirdwebinpackages/thirdweb/src/storage/download.ts.