Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Jan 31, 2025

fixes: CORE-719

TL;DR

Added Knip dependency to the login application for dead code detection

What changed?

  • Added knip version 5.43.6 as a development dependency to the login application
  • Updated pnpm-lock.yaml to reflect the new dependency

How to test?

  1. Run pnpm install in the login application directory
  2. Verify Knip is installed by running pnpm knip --version

Why make this change?

Knip is a static analysis tool that helps identify unused exports, files, and dependencies. Adding this tool will help maintain a cleaner codebase by detecting and removing dead code in the login application.


PR-Codex overview

This PR primarily focuses on updating dependencies in the project, including the addition of new packages and configuration files, as well as refining existing package versions.

Detailed summary

  • Added knip package (version 5.43.6) to apps/login/package.json.
  • Added postcss-load-config package (version ^6.0.1) to apps/login/package.json.
  • Created knip.json configuration file with specific settings.
  • Updated dependencies in pnpm-lock.yaml to reflect new versions and removed some nested dependencies.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Jan 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 8:59pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 8:59pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 8:59pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 8:59pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 8:59pm

@changeset-bot
Copy link

changeset-bot bot commented Jan 31, 2025

⚠️ No Changeset found

Latest commit: 3688141

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jnsdls jnsdls marked this pull request as ready for review January 31, 2025 20:51
@jnsdls jnsdls requested review from a team as code owners January 31, 2025 20:51
Copy link
Member Author

jnsdls commented Jan 31, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@linear
Copy link

linear bot commented Jan 31, 2025

@codecov
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.89%. Comparing base (ca75681) to head (3688141).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6135      +/-   ##
==========================================
+ Coverage   56.87%   56.89%   +0.01%     
==========================================
  Files        1153     1153              
  Lines       63896    63896              
  Branches     5180     5184       +4     
==========================================
+ Hits        36344    36353       +9     
+ Misses      26825    26815      -10     
- Partials      727      728       +1     
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from ca75681
packages 55.08% <ø> (+0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

see 5 files with indirect coverage changes

@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.6 KB (0%) 933 ms (0%) 4.8 s (+66.77% 🔺) 5.7 s
thirdweb (cjs) 122.39 KB (0%) 2.5 s (0%) 5.9 s (-28.82% 🔽) 8.4 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 345 ms (-36.84% 🔽) 457 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 47 ms (-75.75% 🔽) 57 ms
thirdweb/react (minimal + tree-shaking) 19.28 KB (0%) 386 ms (0%) 709 ms (+0.89% 🔺) 1.1 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants