Skip to content

Conversation

@arcoraven
Copy link
Contributor

@arcoraven arcoraven commented Feb 1, 2025

PR-Codex overview

This PR modifies the sendUsageV2Events function in the usageV2.ts file, removing the dependency on the getTopicName function and directly using options.productName for constructing the fetch URL.

Detailed summary

  • Removed the import of getTopicName from ../core/usageV2.js.
  • Changed the fetch URL construction to use options.productName instead of the topic variable.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@arcoraven arcoraven requested a review from a team as a code owner February 1, 2025 04:20
@changeset-bot
Copy link

changeset-bot bot commented Feb 1, 2025

⚠️ No Changeset found

Latest commit: 461023c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Feb 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www 🔄 Building (Inspect) Visit Preview 💬 Add feedback Feb 1, 2025 4:20am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Feb 1, 2025 4:20am
login ⬜️ Skipped (Inspect) Feb 1, 2025 4:20am
thirdweb_playground ⬜️ Skipped (Inspect) Feb 1, 2025 4:20am
wallet-ui ⬜️ Skipped (Inspect) Feb 1, 2025 4:20am

@arcoraven arcoraven merged commit 66833a8 into main Feb 1, 2025
13 of 14 checks passed
@arcoraven arcoraven deleted the ph/usageV2Endpoint branch February 1, 2025 04:21
@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 1, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@codecov
Copy link

codecov bot commented Feb 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.93%. Comparing base (9d5828e) to head (461023c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6140   +/-   ##
=======================================
  Coverage   56.93%   56.93%           
=======================================
  Files        1155     1155           
  Lines       63915    63915           
  Branches     5199     5199           
=======================================
  Hits        36388    36388           
  Misses      26800    26800           
  Partials      727      727           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 9d5828e
packages 55.13% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.6 KB (0%) 933 ms (0%) 577 ms (-10.45% 🔽) 1.6 s
thirdweb (cjs) 122.39 KB (0%) 2.5 s (0%) 1.6 s (+16.87% 🔺) 4.1 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 234 ms (+730.73% 🔺) 346 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 30 ms (+179.17% 🔺) 40 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 185 ms (+11.04% 🔺) 571 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants