Skip to content

Conversation

@kumaryash90
Copy link
Member

@kumaryash90 kumaryash90 commented Feb 1, 2025

TOOL-3279


PR-Codex overview

This PR primarily focuses on improving type imports and formatting in the usageV2.ts and package.json files, as well as adding a new address in the implementations.ts file.

Detailed summary

  • Changed import statement in usageV2.ts to use import type.
  • Added a new address entry in implementations.ts.
  • Reformatted typesVersions and files sections in package.json for consistency.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@kumaryash90 kumaryash90 requested review from a team as code owners February 1, 2025 15:03
@changeset-bot
Copy link

changeset-bot bot commented Feb 1, 2025

⚠️ No Changeset found

Latest commit: b651bae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Feb 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2025 1:22am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2025 1:22am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2025 1:22am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2025 1:22am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2025 1:22am

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Feb 1, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 1, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.6 KB (0%) 933 ms (0%) 279 ms (+49.88% 🔺) 1.3 s
thirdweb (cjs) 122.39 KB (0%) 2.5 s (0%) 525 ms (+12.28% 🔺) 3 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 143 ms (+465.17% 🔺) 254 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 26 ms (+308.41% 🔺) 36 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 92 ms (+111.59% 🔺) 477 ms

@kumaryash90 kumaryash90 added merge-queue Adds the pull request to Graphite's merge queue. hotfix This pull request should be prioritized in the merge queue. labels Feb 1, 2025
Copy link
Member Author

kumaryash90 commented Feb 1, 2025

Merge activity

  • Feb 1, 10:12 AM EST: The merge label 'hotfix' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 1, 8:19 PM EST: A user added this pull request to the Graphite merge queue.
  • Feb 1, 8:22 PM EST: A user merged this pull request with the Graphite merge queue.

@vercel vercel bot temporarily deployed to Preview – wallet-ui February 1, 2025 17:05 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 1, 2025 17:05 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 1, 2025 17:05 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 1, 2025 17:05 Inactive
@codecov
Copy link

codecov bot commented Feb 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.92%. Comparing base (66833a8) to head (b651bae).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6141      +/-   ##
==========================================
- Coverage   56.93%   56.92%   -0.01%     
==========================================
  Files        1155     1155              
  Lines       63915    63916       +1     
  Branches     5199     5192       -7     
==========================================
- Hits        36388    36384       -4     
- Misses      26800    26803       +3     
- Partials      727      729       +2     
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 66833a8
packages 55.12% <100.00%> (-0.01%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
.../src/contract/deployment/zksync/implementations.ts 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

TOOL-3279

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on refining type imports in `usageV2.ts`, adding a new address in `implementations.ts`, and simplifying the `package.json` formatting for better readability.

### Detailed summary
- Changed import style in `usageV2.ts` to use `import type`.
- Added a new address entry in `implementations.ts`.
- Reformatted `typesVersions` and `files` sections in `package.json` for improved clarity.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotfix This pull request should be prioritized in the merge queue. merge-queue Adds the pull request to Graphite's merge queue. packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants