Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Feb 3, 2025


PR-Codex overview

This PR focuses on refactoring and enhancing the user interface components of the dashboard, particularly related to the Toaster notifications and the FaucetButton. It introduces new functionalities and improves the styling and structure of various components.

Detailed summary

  • Removed <Toaster richColors /> from RootLayout.
  • Added ToasterSetup function to manage Toaster theme based on current theme.
  • Updated button styles and added loading states in FaucetButton.
  • Introduced modal for refilling the faucet with funds.
  • Enhanced form handling with validation for faucet refill.
  • Added new UI components for dialog and form inputs.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Feb 3, 2025

@vercel
Copy link

vercel bot commented Feb 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 1:11am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Feb 4, 2025 1:11am
login ⬜️ Skipped (Inspect) Feb 4, 2025 1:11am
thirdweb_playground ⬜️ Skipped (Inspect) Feb 4, 2025 1:11am
wallet-ui ⬜️ Skipped (Inspect) Feb 4, 2025 1:11am

@changeset-bot
Copy link

changeset-bot bot commented Feb 3, 2025

⚠️ No Changeset found

Latest commit: 7972bdf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – login February 3, 2025 19:40 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 3, 2025 19:40 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 3, 2025 19:40 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 3, 2025 19:40 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Feb 3, 2025
@MananTank MananTank marked this pull request as ready for review February 3, 2025 19:40
@MananTank MananTank requested review from a team as code owners February 3, 2025 19:40
Copy link
Member Author

MananTank commented Feb 3, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank changed the title [TOOL-3216] Dashboard: Add Facuet Refill option on testnet chain pages [TOOL-3216] Dashboard: Add Facuet Refill, Fix toast colors on light mode Feb 3, 2025
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 3, 2025 19:41 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 3, 2025 19:41 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 3, 2025 19:41 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 3, 2025 19:41 Inactive
@codecov
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.92%. Comparing base (a51192f) to head (cf166e4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6147   +/-   ##
=======================================
  Coverage   56.92%   56.92%           
=======================================
  Files        1155     1155           
  Lines       63920    63920           
  Branches     5195     5195           
=======================================
  Hits        36388    36388           
  Misses      26804    26804           
  Partials      728      728           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from a51192f
packages 55.13% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.6 KB (+0.03% 🔺) 933 ms (+0.03% 🔺) 3.4 s (-12.9% 🔽) 4.4 s
thirdweb (cjs) 122.38 KB (0%) 2.5 s (0%) 6.5 s (-25.83% 🔽) 9 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 267 ms (-23.5% 🔽) 379 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 114 ms (-32.96% 🔽) 124 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 718 ms (-21.98% 🔽) 1.2 s

@MananTank MananTank changed the title [TOOL-3216] Dashboard: Add Facuet Refill, Fix toast colors on light mode [TOOL-3216] Dashboard: Add Faucet Refill, Fix toast colors on light mode Feb 3, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 4, 2025

Merge activity

…ode (#6147)

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on improving the UI and functionality of the dashboard by updating theme management, enhancing the `FaucetButton` component, and integrating a new modal for refilling the faucet. It also modifies color schemes for buttons and introduces a loading state.

### Detailed summary
- Removed `<Toaster richColors />` from `RootLayout`.
- Added `<ToasterSetup />` component in `AppRouterProviders` for dynamic theming.
- Updated button color schemes in `sdk-component-theme.ts`.
- Enhanced `FaucetButton` with loading states and a new modal for refilling.
- Introduced `SendFundsToFaucetModalButton` and `SendFundsToFaucetModalContent` components.
- Added form validation for the amount in the faucet refill modal.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 4, 2025 01:04 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 4, 2025 01:04 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 4, 2025 01:04 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 4, 2025 01:04 Inactive
@graphite-app graphite-app bot merged commit cf166e4 into main Feb 4, 2025
33 checks passed
@graphite-app graphite-app bot deleted the TOOL-3216 branch February 4, 2025 01:12
@vercel vercel bot temporarily deployed to Production – wallet-ui February 4, 2025 01:12 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 February 4, 2025 01:12 Inactive
@vercel vercel bot temporarily deployed to Production – login February 4, 2025 01:12 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground February 4, 2025 01:12 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants