Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Feb 4, 2025


PR-Codex overview

This PR focuses on refactoring the API context handling in the nebula application, changing how context filters are defined and used, and updating related components to streamline context management.

Detailed summary

  • Updated description type from string to React.ReactNode in APIParameter.
  • Renamed nebulaContextFilterPathParameter to nebulaContextParameter.
  • Changed context filter structure from context_filter to context.
  • Updated context handling in various components to use NebulaContext.
  • Removed references to contractAddresses and adjusted to a single walletAddress.
  • Revised form validation and submission logic to reflect new context structure.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Feb 4, 2025

@vercel
Copy link

vercel bot commented Feb 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 10:06pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 10:06pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
login ⬜️ Skipped (Inspect) Feb 4, 2025 10:06pm
thirdweb_playground ⬜️ Skipped (Inspect) Feb 4, 2025 10:06pm
wallet-ui ⬜️ Skipped (Inspect) Feb 4, 2025 10:06pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui February 4, 2025 18:36 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 4, 2025 18:36 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 4, 2025 18:36 Inactive
@github-actions github-actions bot added Dashboard Involves changes to the Dashboard. Portal Involves changes to the Portal (docs) codebase. labels Feb 4, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank marked this pull request as ready for review February 4, 2025 18:37
@MananTank MananTank requested review from a team as code owners February 4, 2025 18:37
@MananTank MananTank changed the title Dashboard, Docs - Use updated Nebula API [NEB-87] Dashboard, Docs - Use updated Nebula API Feb 4, 2025
@MananTank MananTank marked this pull request as draft February 4, 2025 18:37
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.6 KB (0%) 933 ms (0%) 2.2 s (-15.35% 🔽) 3.2 s
thirdweb (cjs) 122.38 KB (0%) 2.5 s (0%) 7.1 s (+4.58% 🔺) 9.5 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 266 ms (-7.79% 🔽) 378 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 86 ms (+148.46% 🔺) 96 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 593 ms (-10.14% 🔽) 979 ms

@changeset-bot
Copy link

changeset-bot bot commented Feb 4, 2025

⚠️ No Changeset found

Latest commit: 2396b4e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.92%. Comparing base (cf166e4) to head (2396b4e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6157   +/-   ##
=======================================
  Coverage   56.92%   56.92%           
=======================================
  Files        1155     1155           
  Lines       63920    63920           
  Branches     5195     5196    +1     
=======================================
  Hits        36388    36388           
  Misses      26804    26804           
  Partials      728      728           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from cf166e4
packages 55.13% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 4, 2025

Merge activity

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating the API's context handling by replacing the `context_filter` with a simplified `context` structure, changing types, and cleaning up related components to improve clarity and functionality in the codebase.

### Detailed summary
- Changed `description` type from `string` to `React.ReactNode` in `APIParameter`.
- Replaced `nebulaContextFilterPathParameter` and `nebulaExecuteConfigPathParameter` with `nebulaContextParameter`.
- Updated JSON structures to use `context` instead of `context_filter`.
- Modified related API response types and request parameters to align with the new context structure.
- Refactored components to use `NebulaContext` instead of `ContextFilters`.
- Adjusted context handling in various components and functions for consistency.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 4, 2025 21:59 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 4, 2025 21:59 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 4, 2025 21:59 Inactive
@graphite-app graphite-app bot merged commit 2396b4e into main Feb 4, 2025
33 checks passed
@graphite-app graphite-app bot deleted the NEB-87 branch February 4, 2025 22:07
@vercel vercel bot temporarily deployed to Production – thirdweb_playground February 4, 2025 22:07 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui February 4, 2025 22:07 Inactive
@vercel vercel bot temporarily deployed to Production – login February 4, 2025 22:07 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants